Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2bb90ac

Browse files
committed
Support lts/-n aliases
1 parent0bd0676 commit2bb90ac

File tree

3 files changed

+87
-9
lines changed

3 files changed

+87
-9
lines changed

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ The `node-version` input supports the following syntax:
3939

4040
major versions:`12`, `14`, `16`
4141
more specific versions:`10.15`, `14.2.0`, `16.3.0`
42-
nvm lts syntax:`lts/erbium`, `lts/fermium`, `lts/*`
42+
nvm lts syntax:`lts/erbium`, `lts/fermium`, `lts/*`, `lts/-n`
4343

4444
## Caching global packages data
4545

‎__tests__/installer.test.ts‎

Lines changed: 73 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ describe('setup-node', () => {
7777
authSpy.mockImplementation(()=>{});
7878

7979
// gets
80-
getManifestSpy.mockImplementation(
81-
()=><tc.IToolRelease[]>nodeTestManifest
82-
);
80+
getManifestSpy.mockImplementation(()=>[
81+
...(<tc.IToolRelease[]>nodeTestManifest)
82+
]);
8383
getDistSpy.mockImplementation(()=><im.INodeVersion>nodeTestDist);
8484

8585
// writes
@@ -839,6 +839,76 @@ describe('setup-node', () => {
839839
);
840840
});
841841

842+
it('find latest LTS version and resolve it from local cache (lts/-2)',async()=>{
843+
// arrange
844+
inputs['node-version']='lts/-2';
845+
846+
consttoolPath=path.normalize('/cache/node/12.16.2/x64');
847+
findSpy.mockReturnValue(toolPath);
848+
849+
// act
850+
awaitmain.run();
851+
852+
// assert
853+
expect(logSpy).toHaveBeenCalledWith(
854+
'Attempt to resolve LTS alias from manifest...'
855+
);
856+
expect(dbgSpy).toHaveBeenCalledWith(
857+
'Getting manifest from actions/node-versions@main'
858+
);
859+
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached');
860+
expect(dbgSpy).toHaveBeenCalledWith(
861+
`LTS alias '-2' for Node version 'lts/-2'`
862+
);
863+
expect(dbgSpy).toHaveBeenCalledWith(
864+
`Found LTS release '12.16.2' for Node version 'lts/-2'`
865+
);
866+
expect(logSpy).toHaveBeenCalledWith(`Found in cache @${toolPath}`);
867+
expect(cnSpy).toHaveBeenCalledWith(
868+
`::add-path::${path.join(toolPath,'bin')}${osm.EOL}`
869+
);
870+
});
871+
872+
it('find latest LTS version and install it from manifest (lts/-2)',async()=>{
873+
// arrange
874+
inputs['node-version']='lts/-2';
875+
876+
consttoolPath=path.normalize('/cache/node/12.16.2/x64');
877+
findSpy.mockImplementation(()=>'');
878+
dlSpy.mockImplementation(async()=>'/some/temp/path');
879+
exSpy.mockImplementation(async()=>'/some/other/temp/path');
880+
cacheSpy.mockImplementation(async()=>toolPath);
881+
constexpectedUrl=
882+
'https://github.com/actions/node-versions/releases/download/12.16.2-20200423.28/node-12.16.2-linux-x64.tar.gz';
883+
884+
// act
885+
awaitmain.run();
886+
887+
// assert
888+
expect(logSpy).toHaveBeenCalledWith(
889+
'Attempt to resolve LTS alias from manifest...'
890+
);
891+
expect(dbgSpy).toHaveBeenCalledWith(
892+
'Getting manifest from actions/node-versions@main'
893+
);
894+
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached');
895+
expect(dbgSpy).toHaveBeenCalledWith(
896+
`LTS alias '-2' for Node version 'lts/-2'`
897+
);
898+
expect(dbgSpy).toHaveBeenCalledWith(
899+
`Found LTS release '12.16.2' for Node version 'lts/-2'`
900+
);
901+
expect(logSpy).toHaveBeenCalledWith('Attempting to download 12...');
902+
expect(logSpy).toHaveBeenCalledWith(
903+
`Acquiring 12.16.2 -${os.arch} from${expectedUrl}`
904+
);
905+
expect(logSpy).toHaveBeenCalledWith('Extracting ...');
906+
expect(logSpy).toHaveBeenCalledWith('Adding to the cache ...');
907+
expect(cnSpy).toHaveBeenCalledWith(
908+
`::add-path::${path.join(toolPath,'bin')}${osm.EOL}`
909+
);
910+
});
911+
842912
it('fail with unable to parse LTS alias (lts/)',async()=>{
843913
// arrange
844914
inputs['node-version']='lts/';

‎src/installer.ts‎

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export async function getNode(
4545

4646
// No try-catch since it's not possible to resolve LTS alias without manifest
4747
manifest=awaitgetManifest(auth);
48+
manifest.reverse();
4849

4950
versionSpec=resolveLtsAliasFromManifest(versionSpec,stable,manifest);
5051
}
@@ -216,13 +217,20 @@ function resolveLtsAliasFromManifest(
216217

217218
core.debug(`LTS alias '${alias}' for Node version '${versionSpec}'`);
218219

219-
// Supported formats are `lts/<alias>` and `lts/*`. Where asterisk means highest possible LTS.
220+
// Supported formats are `lts/<alias>`, `lts/*`, and `lts/-n`. Where asterisk means highest possible LTS and -n means the nth-highest.
221+
constn=Number(alias);
222+
constaliases=Object.fromEntries(
223+
manifest
224+
.filter(x=>x.stable===stable)
225+
.map(x=>[x.lts?.toLowerCase(),x])
226+
);
227+
constnumbered=Object.values(aliases);
220228
constrelease=
221229
alias==='*'
222-
?manifest.find(x=>!!x.lts&&x.stable===stable)
223-
:manifest.find(
224-
x=>x.lts?.toLowerCase()===alias&&x.stable===stable
225-
);
230+
?numbered[numbered.length-1]
231+
:n<0
232+
?numbered[numbered.length-1+n]
233+
:aliases[alias];
226234

227235
if(!release){
228236
thrownewError(

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp