NotificationsYou must be signed in to change notification settings
Fork614
Star1.6k

Commit3d65fa5

committed

feat: bump to use actions/checkout@v4

Signed-off-by: Rui Chen <rui@chenrui.dev>

1 parent8a505c9 commit3d65fa5Copy full SHA for 3d65fa5

File tree

4 files changed

+36

-36

lines changed

.github/workflows
- versions.yml
- windows-validation.yml
README.md
docs/adrs
- 0000-caching-dependencies.md

4 files changed

+36

-36

lines changed

`‎.github/workflows/versions.yml‎`

Lines changed: 10 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ jobs:`
`20`	`20`	`matrix:`
`21`	`21`	`os:[ubuntu-latest, windows-latest, macos-latest]`
`22`	`22`	`steps:`
`23`		`- -uses:actions/checkout@v3`
	`23`	`+ -uses:actions/checkout@v4`
`24`	`24`	`-name:Setup Go Stable`
`25`	`25`	`uses:./`
`26`	`26`	`with:`
`@@ -35,7 +35,7 @@ jobs:`
`35`	`35`	`matrix:`
`36`	`36`	`os:[ubuntu-latest, windows-latest, macos-latest]`
`37`	`37`	`steps:`
`38`		`- -uses:actions/checkout@v3`
	`38`	`+ -uses:actions/checkout@v4`
`39`	`39`	`-name:Setup Go oldStable`
`40`	`40`	`uses:./`
`41`	`41`	`with:`
`@@ -55,7 +55,7 @@ jobs:`
`55`	`55`	`-os:macos-latest`
`56`	`56`	`architecture:x32`
`57`	`57`	`steps:`
`58`		`- -uses:actions/checkout@v3`
	`58`	`+ -uses:actions/checkout@v4`
`59`	`59`	`-name:Setup Go ${{ matrix.version }} ${{ matrix.architecture }}`
`60`	`60`	`uses:./`
`61`	`61`	`with:`
`@@ -74,7 +74,7 @@ jobs:`
`74`	`74`	`go:[1.17, 1.18, 1.19]`
`75`	`75`	`steps:`
`76`	`76`	`-name:Checkout`
`77`		`-uses:actions/checkout@v3`
	`77`	`+uses:actions/checkout@v4`
`78`	`78`
`79`	`79`	`-name:setup-go ${{ matrix.go }}`
`80`	`80`	`uses:./`
`@@ -93,7 +93,7 @@ jobs:`
`93`	`93`	`os:[ubuntu-latest, windows-latest, macos-latest]`
`94`	`94`	`go-version:[1.16, 1.17]`
`95`	`95`	`steps:`
`96`		`- -uses:actions/checkout@v3`
	`96`	`+ -uses:actions/checkout@v4`
`97`	`97`	`-name:Setup Go and check latest`
`98`	`98`	`uses:./`
`99`	`99`	`with:`
`@@ -109,7 +109,7 @@ jobs:`
`109`	`109`	`matrix:`
`110`	`110`	`os:[ubuntu-latest, windows-latest, macos-latest]`
`111`	`111`	`steps:`
`112`		`- -uses:actions/checkout@v3`
	`112`	`+ -uses:actions/checkout@v4`
`113`	`113`	`-name:Setup Go and check latest`
`114`	`114`	`uses:./`
`115`	`115`	`with:`
`@@ -125,7 +125,7 @@ jobs:`
`125`	`125`	`matrix:`
`126`	`126`	`os:[ubuntu-latest, windows-latest, macos-latest]`
`127`	`127`	`steps:`
`128`		`- -uses:actions/checkout@v3`
	`128`	`+ -uses:actions/checkout@v4`
`129`	`129`	`-name:Setup Go and check latest`
`130`	`130`	`uses:./`
`131`	`131`	`with:`
`@@ -144,7 +144,7 @@ jobs:`
`144`	`144`	`go:[1.12.16, 1.13.11, 1.14.3]`
`145`	`145`	`steps:`
`146`	`146`	`-name:Checkout`
`147`		`-uses:actions/checkout@v3`
	`147`	`+uses:actions/checkout@v4`
`148`	`148`
`149`	`149`	`-name:setup-go ${{ matrix.go }}`
`150`	`150`	`uses:./`
`@@ -165,7 +165,7 @@ jobs:`
`165`	`165`	`go:[1.9, 1.8.6]`
`166`	`166`	`steps:`
`167`	`167`	`-name:Checkout`
`168`		`-uses:actions/checkout@v3`
	`168`	`+uses:actions/checkout@v4`
`169`	`169`
`170`	`170`	`-name:setup-go ${{ matrix.go }}`
`171`	`171`	`uses:./`
`@@ -184,7 +184,7 @@ jobs:`
`184`	`184`	`os:[ubuntu-latest, windows-latest, macos-latest]`
`185`	`185`	`go-version:[1.16, 1.17]`
`186`	`186`	`steps:`
`187`		`- -uses:actions/checkout@v3`
	`187`	`+ -uses:actions/checkout@v4`
`188`	`188`	`-name:Setup Go and check latest`
`189`	`189`	`uses:./`
`190`	`190`	`with:`

`‎.github/workflows/windows-validation.yml‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ jobs:`
`19`	`19`	`cache:[false, true]`
`20`	`20`	`go:[1.20.1]`
`21`	`21`	`steps:`
`22`		`- -uses:actions/checkout@v3`
	`22`	`+ -uses:actions/checkout@v4`
`23`	`23`
`24`	`24`	`-name:'Setup ${{ matrix.cache }}, cache: ${{ matrix.go }}'`
`25`	`25`	`uses:./`
`@@ -61,7 +61,7 @@ jobs:`
`61`	`61`	`echo 'which go should return "/c/hostedtoolcache/windows/go/${{ matrix.go }}/x64/bin/go"'`
`62`	`62`	`exit 1`
`63`	`63`	`fi`
`64`		`- if [ $(go env GOROOT) != 'C:\hostedtoolcache\windows\go\${{ matrix.go }}\x64' ];then`
	`64`	`+ if [ $(go env GOROOT) != 'C:\hostedtoolcache\windows\go\${{ matrix.go }}\x64' ];then`
`65`	`65`	`echo 'go env GOROOT should return "C:\hostedtoolcache\windows\go\${{ matrix.go }}\x64"'`
`66`	`66`	`exit 1`
`67`	`67`	`fi`
`@@ -88,7 +88,7 @@ jobs:`
`88`	`88`	`matrix:`
`89`	`89`	`cache:[false, true]`
`90`	`90`	`steps:`
`91`		`- -uses:actions/checkout@v3`
	`91`	`+ -uses:actions/checkout@v4`
`92`	`92`
`93`	`93`	`-name:'Setup default go, cache: ${{ matrix.cache }}'`
`94`	`94`	`uses:./`
`@@ -121,7 +121,7 @@ jobs:`
`121`	`121`	`cache:[false]`
`122`	`122`	`go:[1.20.1]`
`123`	`123`	`steps:`
`124`		`- -uses:actions/checkout@v3`
	`124`	`+ -uses:actions/checkout@v4`
`125`	`125`
`126`	`126`	`-name:'Setup ${{ matrix.go }}, cache: ${{ matrix.cache }}'`
`127`	`127`	`uses:./`

`‎README.md‎`

Lines changed: 16 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ Matching by [semver spec](https://github.com/npm/node-semver):`
`42`	`42`
`43`	`43`	```yaml
`44`	`44`	`steps:`
`45`		`- -uses:actions/checkout@v3`
	`45`	`+ -uses:actions/checkout@v4`
`46`	`46`	`-uses:actions/setup-go@v4`
`47`	`47`	`with:`
`48`	`48`	`go-version:'^1.13.1'# The Go version to download (if necessary) and use.`
`@@ -51,25 +51,25 @@ steps:`
`51`	`51`
`52`	`52`	```yaml
`53`	`53`	`steps:`
`54`		`- -uses:actions/checkout@v3`
	`54`	`+ -uses:actions/checkout@v4`
`55`	`55`	`-uses:actions/setup-go@v4`
`56`	`56`	`with:`
`57`	`57`	`go-version:'>=1.17.0'`
`58`	`58`	`-run:go version`
`59`	`59`	```
`60`	`60`
`61`	`61`	`> Note: Due to the peculiarities of YAML parsing, it is recommended to wrap the version in single quotation marks:`
`62`		`->`
	`62`	`+>`
`63`	`63`	>```yaml
`64`	`64`	`> go-version: '1.20'`
`65`	`65`	> ```
`66`		`->`
	`66`	`+>`
`67`	`67`	`> The recommendation is based on the YAML parser's behavior, which interprets non-wrapped values as numbers and, in the case of version 1.20, trims it down to 1.2, which may not be very obvious.`
`68`	`68`	`Matching an unstable pre-release:`
`69`	`69`
`70`	`70`	```yaml
`71`	`71`	`steps:`
`72`		`- - uses: actions/checkout@v3`
	`72`	`+ - uses: actions/checkout@v4`
`73`	`73`	`- uses: actions/setup-go@v4`
`74`	`74`	`with:`
`75`	`75`	`go-version: '1.18.0-rc.1' # The Go version to download (if necessary) and use.`
`@@ -78,7 +78,7 @@ steps:`
`78`	`78`
`79`	`79`	```yaml
`80`	`80`	`steps:`
`81`		`- - uses: actions/checkout@v3`
	`81`	`+ - uses: actions/checkout@v4`
`82`	`82`	`- uses: actions/setup-go@v4`
`83`	`83`	`with:`
`84`	`84`	`go-version: '1.16.0-beta.1' # The Go version to download (if necessary) and use.`
`@@ -93,7 +93,7 @@ See [action.yml](action.yml)`
`93`	`93`
`94`	`94`	```yaml
`95`	`95`	`steps:`
`96`		`- - uses: actions/checkout@v3`
	`96`	`+ - uses: actions/checkout@v4`
`97`	`97`	`- uses: actions/setup-go@v4`
`98`	`98`	`with:`
`99`	`99`	`go-version: '1.16.1' # The Go version to download (if necessary) and use.`
`@@ -114,7 +114,7 @@ want the most up-to-date Go version to always be used.`
`114`	`114`
`115`	`115`	```yaml
`116`	`116`	`steps:`
`117`		`- - uses: actions/checkout@v3`
	`117`	`+ - uses: actions/checkout@v4`
`118`	`118`	`- uses: actions/setup-go@v4`
`119`	`119`	`with:`
`120`	`120`	`go-version: '1.14'`
@@ -135,7 +135,7 @@ set to `true`
`135`	`135`
`136`	`136`	```yaml
`137`	`137`	`steps:`
`138`		`- - uses: actions/checkout@v3`
	`138`	`+ - uses: actions/checkout@v4`
`139`	`139`	`- uses: actions/setup-go@v4`
`140`	`140`	`with:`
`141`	`141`	`go-version: 'stable'`
`@@ -144,7 +144,7 @@ steps:`
`144`	`144`
`145`	`145`	```yaml
`146`	`146`	`steps:`
`147`		`- - uses: actions/checkout@v3`
	`147`	`+ - uses: actions/checkout@v4`
`148`	`148`	`- uses: actions/setup-go@v4`
`149`	`149`	`with:`
`150`	`150`	`go-version: 'oldstable'`
`@@ -161,20 +161,20 @@ The action defaults to search for the dependency file - go.sum in the repository`
`161`	`161`	the cache key. Use `cache-dependency-path` input for cases when multiple dependency files are used, or they are located
`162`	`162`	`in different subdirectories. The input supports glob patterns.`
`163`	`163`
`164`		`-If some problem that prevents success caching happens then the action issues the warning in the log and continues the execution of the pipeline.`
	`164`	`+If some problem that prevents success caching happens then the action issues the warning in the log and continues the execution of the pipeline.`
`165`	`165`
`166`	`166`	`Caching in monorepos`
`167`	`167`
`168`	`168`	```yaml
`169`	`169`	`steps:`
`170`		`- - uses: actions/checkout@v3`
	`170`	`+ - uses: actions/checkout@v4`
`171`	`171`	`- uses: actions/setup-go@v4`
`172`	`172`	`with:`
`173`	`173`	`go-version: '1.17'`
`174`	`174`	`check-latest: true`
`175`	`175`	`cache-dependency-path: \|`
`176`		`- subdir/go.sum`
`177`		`- tools/go.sum`
	`176`	`+ subdir/go.sum`
	`177`	`+ tools/go.sum`
`178`	`178`	`# cache-dependency-path: "*/.sum"`
`179`	`179`
`180`	`180`	`- run: go run hello.go`
@@ -193,7 +193,7 @@ If both the `go-version` and the `go-version-file` inputs are provided then the
`193`	`193`
`194`	`194`	```yaml
`195`	`195`	`steps:`
`196`		`- - uses: actions/checkout@v3`
	`196`	`+ - uses: actions/checkout@v4`
`197`	`197`	`- uses: actions/setup-go@v4`
`198`	`198`	`with:`
`199`	`199`	`go-version-file: 'path/to/go.mod'`
`@@ -211,7 +211,7 @@ jobs:`
`211`	`211`	`go: [ '1.14', '1.13' ]`
`212`	`212`	`name: Go ${{ matrix.go }} sample`
`213`	`213`	`steps:`
`214`		`- - uses: actions/checkout@v3`
	`214`	`+ - uses: actions/checkout@v4`
`215`	`215`	`- name: Setup go`
`216`	`216`	`uses: actions/setup-go@v4`
`217`	`217`	`with:`

`‎docs/adrs/0000-caching-dependencies.md‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ Date: 2022-04-13`
`4`	`4`	`Status: Accepted`
`5`	`5`
`6`	`6`	`#Context`
`7`		-`actions/setup-go` is the one of the most popular action related to Golang in GitHub Actions. Many customers use it in conjunction with[actions/cache](https://github.com/actions/cache) to speed up dependency installation process.
	`7`	+`actions/setup-go` is the one of the most popular action related to Golang in GitHub Actions. Many customers use it in conjunction with[actions/cache](https://github.com/actions/cache) to speed up dependency installation process.
`8`	`8`	`See more examples on proper usage in[actions/cache documentation](https://github.com/actions/cache/blob/main/examples.md#go---modules).`
`9`	`9`
`10`	`10`	`#Goals & Anti-Goals`
@@ -16,7 +16,7 @@ Integration of caching functionality into `actions/setup-go` action will bring t
`16`	`16`	We don't pursue the goal to provide wide customization of caching in scope of`actions/setup-go` action. The purpose of this integration is covering~90% of basic use-cases. If user needs flexible customization, we should advice them to use`actions/cache` directly.
`17`	`17`
`18`	`18`	`#Decision`
`19`		-- Add`cache` input parameter to`actions/setup-go`. For now, input will accept the following values:
	`19`	+- Add`cache` input parameter to`actions/setup-go`. For now, input will accept the following values:
`20`	`20`	-`true` - enable caching for go dependencies
`21`	`21`	-`false`- disable caching for go dependencies. This value will be set as default value
`22`	`22`	`- Cache feature will be disabled by default to make sure that we don't break existing customers. We will consider enabling cache by default in next major releases`
@@ -32,7 +32,7 @@ We don't pursue the goal to provide wide customization of caching in scope of `a
`32`	`32`
`33`	`33`	```yml
`34`	`34`	`steps:`
`35`		`--uses:actions/checkout@v3`
	`35`	`+-uses:actions/checkout@v4`
`36`	`36`	`-uses:actions/setup-go@v3`
`37`	`37`	`with:`
`38`	`38`	`go-version:'18'`
`@@ -43,7 +43,7 @@ steps:`
`43`	`43`
`44`	`44`	```yml
`45`	`45`	`steps:`
`46`		`--uses:actions/checkout@v3`
	`46`	`+-uses:actions/checkout@v4`
`47`	`47`	`-uses:actions/setup-go@v3`
`48`	`48`	`with:`
`49`	`49`	`go-version:'18'`
`@@ -53,7 +53,7 @@ steps:`
`53`	`53`
`54`	`54`	```yml
`55`	`55`	`steps:`
`56`		`--uses:actions/checkout@v3`
	`56`	`+-uses:actions/checkout@v4`
`57`	`57`	`-uses:actions/setup-go@v3`
`58`	`58`	`with:`
`59`	`59`	`go-version:'18'`
`@@ -66,4 +66,4 @@ steps:`
`66`	`66`	`# Release process`
`67`	`67`
`68`	`68`	`As soon as functionality is implemented, we will release minor update of action. No need to bump major version since there are no breaking changes for existing users.`
`69`		`-After that, we will update [starter-workflows](https://github.com/actions/starter-workflows/blob/main/ci/go.yml)`
	`69`	`+After that, we will update [starter-workflows](https://github.com/actions/starter-workflows/blob/main/ci/go.yml)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3d65fa5

File tree

4 files changed

4 files changed

`‎.github/workflows/versions.yml‎`

`‎.github/workflows/windows-validation.yml‎`

`‎README.md‎`

`‎docs/adrs/0000-caching-dependencies.md‎`

0 commit comments