Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Own prs#359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mjpieters wants to merge3 commits intoactions:mainfrommjpieters:own_prs
Closed

Own prs#359

mjpieters wants to merge3 commits intoactions:mainfrommjpieters:own_prs

Conversation

mjpieters
Copy link
Contributor

There are my three PRs against the original action, so I can use these until there is a new release.

The @octokit/plugin- references are not actually (directly) used by@action/github-script and so only serve to confuse about what exactversion of these is included in the action. The actual versions ofthese plugins are set by @action/github.Ignoring newlines, the dist/index.js file is exactly the same withoutlisting these dependencies in package.json.
`core.getInput()` always returns a string, so testing for 'not null'is always true. This then leads to previews set to an array witha single empty string, breaking accept-header output.Updated eslint rules should help avoid this issue in future, and newintegration tests verify that the github client configuration nowreflects the intended configuration options.
Without this plugin, the debug setting is, effectively, meaningless asnone of the existing plugins produce log output.The plugin writes the request options to octokit.log.debug, and responsetimes as *method path - status in ...ms* to octokit.log.info.
@mjpietersmjpieters requested a review froma teamMarch 30, 2023 15:10
@mjpieters
Copy link
ContributorAuthor

Mea culpa, this was meant to go into my own fork.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@mjpieters

[8]ページ先頭

©2009-2025 Movatter.jp