- Notifications
You must be signed in to change notification settings - Fork455
Own prs#359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Own prs#359
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The @octokit/plugin- references are not actually (directly) used by@action/github-script and so only serve to confuse about what exactversion of these is included in the action. The actual versions ofthese plugins are set by @action/github.Ignoring newlines, the dist/index.js file is exactly the same withoutlisting these dependencies in package.json.
`core.getInput()` always returns a string, so testing for 'not null'is always true. This then leads to previews set to an array witha single empty string, breaking accept-header output.Updated eslint rules should help avoid this issue in future, and newintegration tests verify that the github client configuration nowreflects the intended configuration options.
Without this plugin, the debug setting is, effectively, meaningless asnone of the existing plugins produce log output.The plugin writes the request options to octokit.log.debug, and responsetimes as *method path - status in ...ms* to octokit.log.info.
Mea culpa, this was meant to go into my own fork. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are my three PRs against the original action, so I can use these until there is a new release.