- Notifications
You must be signed in to change notification settings - Fork455
fix input handling#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
mjpieters commentedMar 30, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Seehttps://github.com/actions/github-script/actions/runs/4611973839 for an example of what the integration test summaries look like. |
- Use test-specific step ids- Remove unused input parameters- Provide clear output on what passed or failed, including a step summary for each passed test.
Uh oh!
There was an error while loading.Please reload this page.
joshmgross approved these changesApr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Left one suggestion, but not a blocker. Thanks for adding all those integration tests!
`core.getInput()` always returns a string, so testing for 'not null'is always true. This then leads to previews set to an array witha single empty string, breaking accept-header output.Updated eslint rules should help avoid this issue in future, and newintegration tests verify that the github client configuration nowreflects the intended configuration options.
joshmgross approved these changesApr 4, 2023
renovatebot referenced this pull request in JoshuaKGoldberg/create-typescript-appApr 8, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | patch | `v6.4.0` -> `v6.4.1` |---### Release Notes<details><summary>actions/github-script</summary>###[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)#### What's Changed- Add[@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),to produce debug output for requests by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)- fix input handling by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357)- Remove unused dependencies by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356)- Default debug to current runner debug state by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363)#### New Contributors- [@​mjpieters](https://togithub.com/mjpieters) made their firstcontribution in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)**Full Changelog**:actions/github-script@v6.4.0...v6.4.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/JoshuaKGoldberg/template-typescript-node-package).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzcuMSJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
renovatebot referenced this pull request in JoshuaKGoldberg/ts-api-utilsApr 8, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | patch | `v6.4.0` -> `v6.4.1` |---### Release Notes<details><summary>actions/github-script</summary>###[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)##### What's Changed- Add[@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),to produce debug output for requests by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)- fix input handling by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357)- Remove unused dependencies by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356)- Default debug to current runner debug state by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363)##### New Contributors- [@​mjpieters](https://togithub.com/mjpieters) made their firstcontribution in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)**Full Changelog**:actions/github-script@v6.4.0...v6.4.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/JoshuaKGoldberg/ts-api-utils).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzcuMSJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh referenced this pull request in DeFiCh/jellyfishsdkApr 10, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | patch | `v6.4.0` -> `v6.4.1` |---### Release Notes<details><summary>actions/github-script</summary>###[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)##### What's Changed- Add[@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),to produce debug output for requests by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)- fix input handling by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357)- Remove unused dependencies by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356)- Default debug to current runner debug state by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363)##### New Contributors- [@​mjpieters](https://togithub.com/mjpieters) made their firstcontribution in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)**Full Changelog**:actions/github-script@v6.4.0...v6.4.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzcuMSJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kayman-mk referenced this pull request in Hapag-Lloyd/Renovate-Global-ConfigurationNov 19, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | major | `v6.4.0` -> `v7.0.1` |---### Release Notes<details><summary>actions/github-script (actions/github-script)</summary>###[`v7.0.1`](https://togithub.com/actions/github-script/releases/tag/v7.0.1)[CompareSource](https://togithub.com/actions/github-script/compare/v7.0.0...v7.0.1)##### What's Changed- Avoid setting `baseUrl` to undefined when input is not provided by[@​joshmgross](https://togithub.com/joshmgross) in[https://github.com/actions/github-script/pull/439](https://togithub.com/actions/github-script/pull/439)**Full Changelog**:actions/github-script@v7.0.0...v7.0.1###[`v7.0.0`](https://togithub.com/actions/github-script/releases/tag/v7.0.0)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.1...v7.0.0)##### What's Changed- Add base-url option by[@​robandpdx](https://togithub.com/robandpdx) in[https://github.com/actions/github-script/pull/429](https://togithub.com/actions/github-script/pull/429)- Expose async-function argument type by[@​viktorlott](https://togithub.com/viktorlott) in[https://github.com/actions/github-script/pull/402](https://togithub.com/actions/github-script/pull/402),see for detailshttps://github.com/actions/github-script#use-scripts-with-jsdoc-support- Update dependencies and use Node 20 by[@​joshmgross](https://togithub.com/joshmgross) in[https://github.com/actions/github-script/pull/425](https://togithub.com/actions/github-script/pull/425)##### New Contributors- [@​navarroaxel](https://togithub.com/navarroaxel) made theirfirst contribution in[https://github.com/actions/github-script/pull/285](https://togithub.com/actions/github-script/pull/285)- [@​robandpdx](https://togithub.com/robandpdx) made their firstcontribution in[https://github.com/actions/github-script/pull/429](https://togithub.com/actions/github-script/pull/429)- [@​viktorlott](https://togithub.com/viktorlott) made their firstcontribution in[https://github.com/actions/github-script/pull/402](https://togithub.com/actions/github-script/pull/402)**Full Changelog**:actions/github-script@v6.4.1...v7.0.0###[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)#### What's Changed- Add[@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),to produce debug output for requests by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)- fix input handling by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357)- Remove unused dependencies by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356)- Default debug to current runner debug state by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363)#### New Contributors- [@​mjpieters](https://togithub.com/mjpieters) made their firstcontribution in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)**Full Changelog**:actions/github-script@v6.4.0...v6.4.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR is behind base branch, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kayman-mk referenced this pull request in Hapag-Lloyd/terraform-aws-bastion-host-ssmNov 23, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | patch | `v6.4.0` -> `v6.4.1` |---### Release Notes<details><summary>actions/github-script (actions/github-script)</summary>###[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)#### What's Changed- Add[@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),to produce debug output for requests by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)- fix input handling by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357)- Remove unused dependencies by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356)- Default debug to current runner debug state by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363)#### New Contributors- [@​mjpieters](https://togithub.com/mjpieters) made their firstcontribution in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)**Full Changelog**:actions/github-script@v6.4.0...v6.4.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/Hapag-Lloyd/terraform-aws-bastion-host-ssm).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovatebot referenced this pull request in Hapag-Lloyd/dist-comm-visNov 23, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | patch | `v6.4.0` -> `v6.4.1` |---### Release Notes<details><summary>actions/github-script (actions/github-script)</summary>###[`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1)#### What's Changed- Add[@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log),to produce debug output for requests by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)- fix input handling by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357)- Remove unused dependencies by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356)- Default debug to current runner debug state by[@​mjpieters](https://togithub.com/mjpieters) in[https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363)#### New Contributors- [@​mjpieters](https://togithub.com/mjpieters) made their firstcontribution in[https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358)**Full Changelog**:actions/github-script@v6.4.0...v6.4.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/Hapag-Lloyd/dist-comm-vis).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
vbraun pushed a commit to vbraun/sage that referenced this pull requestDec 9, 2023
sagemathgh-36739: ⬆️ Bump actions/github-script from 6.4.0 to 7.0.1 Bumps [actions/github-script](https://github.com/actions/github-script)from 6.4.0 to 7.0.1.<details><summary>Release notes</summary><p><em>Sourced from <a href="https://github.com/actions/github-script/releases">actions/github-script's releases</a>.</em></p><blockquote><h2>v7.0.1</h2><h2>What's Changed</h2><ul><li>Avoid setting <code>baseUrl</code> to undefined when input is notprovided by <ahref="https://github.com/joshmgross"><code>@joshmgross</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/439">actions/github-script#439</a></li></ul><p><strong>Full Changelog</strong>: <ahref="https://github.com/actions/github-script/compare/v7.0.0...v7.0.1">https://github.com/actions/github-script/compare/v7.0.0...v7.0.1</a></p><h2>v7.0.0</h2><h2>What's Changed</h2><ul><li>Add base-url option by <ahref="https://github.com/robandpdx"><code>@robandpdx</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/429">actions/github-script#429</a></li><li>Expose async-function argument type by <ahref="https://github.com/viktorlott"><code>@viktorlott</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/402">actions/github-script#402</a>, see for details <ahref="https://github.com/actions/github-script#use-scripts-with-jsdoc-support">https://github.com/actions/github-script#use-scripts-with-jsdoc-support</a></li><li>Update dependencies and use Node 20 by <ahref="https://github.com/joshmgross"><code>@joshmgross</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/425">actions/github-script#425</a></li></ul><h2>New Contributors</h2><ul><li><ahref="https://github.com/navarroaxel"><code>@navarroaxel</code></a>made their first contribution in <ahref="https://redirect.github.com/actions/github-script/pull/285">actions/github-script#285</a></li><li><a href="https://github.com/robandpdx"><code>@robandpdx</code></a>made their first contribution in <ahref="https://redirect.github.com/actions/github-script/pull/429">actions/github-script#429</a></li><li><ahref="https://github.com/viktorlott"><code>@viktorlott</code></a> madetheir first contribution in <ahref="https://redirect.github.com/actions/github-script/pull/402">actions/github-script#402</a></li></ul><p><strong>Full Changelog</strong>: <ahref="https://github.com/actions/github-script/compare/v6.4.1...v7.0.0">https://github.com/actions/github-script/compare/v6.4.1...v7.0.0</a></p><h2>v6.4.1</h2><h2>What's Changed</h2><ul><li>Add <code>@octokit/plugin-request-log</code>, to produce debugoutput for requests by <ahref="https://github.com/mjpieters"><code>@mjpieters</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/358">actions/github-script#358</a></li><li>fix input handling by <ahref="https://github.com/mjpieters"><code>@mjpieters</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/357">actions/github-script#357</a></li><li>Remove unused dependencies by <ahref="https://github.com/mjpieters"><code>@mjpieters</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/356">actions/github-script#356</a></li><li>Default debug to current runner debug state by <ahref="https://github.com/mjpieters"><code>@mjpieters</code></a> in <ahref="https://redirect.github.com/actions/github-script/pull/363">actions/github-script#363</a></li></ul><h2>New Contributors</h2><ul><li><a href="https://github.com/mjpieters"><code>@mjpieters</code></a>made their first contribution in <ahref="https://redirect.github.com/actions/github-script/pull/358">actions/github-script#358</a></li></ul><p><strong>Full Changelog</strong>: <ahref="https://github.com/actions/github-script/compare/v6.4.0...v6.4.1">https://github.com/actions/github-script/compare/v6.4.0...v6.4.1</a></p></blockquote></details><details><summary>Commits</summary><ul><li><a href="actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea"><code>60a0d83</code></a> Merge pullrequest <a href="https://redirect.github.com/actions/github-script/issues/440">sagemath#440</a> from actions/joshmgross/v7.0.1</li><li><a href="actions/github-script@b7fb2001b410c9390cbe9e2c7d5cab7eefb7b29c"><code>b7fb200</code></a> Update versionto 7.0.1</li><li><a href="actions/github-script@12e22ed06b6cf302663f90a925045516e24c8bad"><code>12e22ed</code></a> Merge pullrequest <a href="https://redirect.github.com/actions/github-script/issues/439">sagemath#439</a> from actions/joshmgross/avoid-setting-base-url</li><li><a href="actions/github-script@d319f8f5b55ea40916b869b2ca9ae2f059c60abf"><code>d319f8f</code></a> Avoid setting<code>baseUrl</code> to undefined when input is not provided</li><li><a href="actions/github-script@e69ef5462fd455e02edcaf4dd7708eda96b9eda0"><code>e69ef54</code></a> Merge pullrequest <a href="https://redirect.github.com/actions/github-script/issues/425">sagemath#425</a> from actions/joshmgross/node-20</li><li><a href="actions/github-script@ee0914b839b704083a749f8c77a73a9270674a32"><code>ee0914b</code></a> Updatelicenses</li><li><a href="actions/github-script@d6fc56f33b017d55917d045da1a94efa2120f039"><code>d6fc56f</code></a> Use<code>@types/node</code> for Node 20</li><li><a href="actions/github-script@384d6cf581452587d1e31f553c97ab165427124a"><code>384d6cf</code></a> Fix quotationsin tests</li><li><a href="actions/github-script@84724927e3e992f17768c17f57a47a85ea2a5160"><code>8472492</code></a> Only validateGraphQL <code>previews</code></li><li><a href="actions/github-script@84903f51828821af5d03d3884c6ba699a2d44d6e"><code>84903f5</code></a> Remove<code>node-fetch</code> from type</li><li>Additional commits viewable in <ahref="https://github.com/actions/github-script/compare/v6.4.0...v7.0.1">compare view</a></li></ul></details><br />[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don'talter it yourself. You can also trigger a rebase manually by commenting`@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---<details><summary>Dependabot commands and options</summary><br />You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any editsthat have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR afteryour CI passes on it- `@dependabot cancel merge` will cancel a previously requested mergeand block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreatingit. You can achieve the same result by closing it manually- `@dependabot show <dependency name> ignore conditions` will show allof the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stopDependabot creating any more for this major version (unless you reopenthe PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stopDependabot creating any more for this minor version (unless you reopenthe PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stopDependabot creating any more for this dependency (unless you reopen thePR or upgrade to it yourself)</details> URL:sagemath#36739Reported by: dependabot[bot]Reviewer(s): Kwankyu Lee
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR fixes how github-script handles the inputs given, which in turn
unbreaks how the Octokit request defaults are set.
I've included an extra ESLint rule to guard against the error in future, as
well as expanded the integration tests to cover action settings better.
core.getInput()always returns a string, so testing for 'not null' is always true. This then leads to previews set to an array with a single empty string, breaking accept-header output.Fixes#243