- Notifications
You must be signed in to change notification settings - Fork455
Add node-fetch#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Add node-fetch#321
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Looks like the |
Actually that's failing on |
joshmgross approved these changesJan 26, 2023
Thanks for your contribution! I'll go ahead and release a new version with this |
Merged
This is now available inhttps://github.com/actions/github-script/releases/tag/v6.4.0 I'll update |
fuxingloh referenced this pull request in DeFiCh/jellyfishsdkJan 31, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | minor | `v6.3.3` -> `v6.4.0` |---### Release Notes<details><summary>actions/github-script</summary>###[`v6.4.0`](https://togithub.com/actions/github-script/releases/tag/v6.4.0)[CompareSource](https://togithub.com/actions/github-script/compare/v6.3.3...v6.4.0)##### What's Changed- Bump json5 from 2.1.3 to 2.2.3 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/actions/github-script/pull/319](https://togithub.com/actions/github-script/pull/319)- Bump minimatch from 3.0.4 to 3.1.2 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/actions/github-script/pull/320](https://togithub.com/actions/github-script/pull/320)- Add node-fetch by[@​danmichaelo](https://togithub.com/danmichaelo) in[https://github.com/actions/github-script/pull/321](https://togithub.com/actions/github-script/pull/321)##### New Contributors- [@​jongwooo](https://togithub.com/jongwooo) made their firstcontribution in[https://github.com/actions/github-script/pull/313](https://togithub.com/actions/github-script/pull/313)- [@​austinvazquez](https://togithub.com/austinvazquez) made theirfirst contribution in[https://github.com/actions/github-script/pull/306](https://togithub.com/actions/github-script/pull/306)- [@​danmichaelo](https://togithub.com/danmichaelo) made theirfirst contribution in[https://github.com/actions/github-script/pull/321](https://togithub.com/actions/github-script/pull/321)**Full Changelog**:actions/github-script@v6.3.3...v6.4.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/JellyfishSDK/jellyfish).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExMS4xIn0=-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#305
Installed node-fetch 2.6.7, which is the same version used by
@octokit/request:The bundle size only increased from 772,787 to 772,991 bytes, so seems like re-use works well.
If we installed node-fetch 3 instead, the bundle size would increase to 1,045,047 bytes. Most likely the difference would hardly be noticeable, but on the other hand there aren't that many important improvements in node-fetch 3 as far as I'm aware, so perhaps it's still better to use node-fetch 2 to save 270 kB?
Of course, once Node18 is available from GitHub, node-fetch is no longer needed, but seems like that may take some time.
(Updated ncc because I had a build problem with node-fetch 3)