- Notifications
You must be signed in to change notification settings - Fork455
Add retry plugin and related options#288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you bump the version to6.2.1
inpackage.json
?
src/retry-options.ts Outdated
retries | ||
} | ||
core.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should this be debug?
Users might not want every step to output this information
@joshmgross what do you think about 6.3.0 since this is adding a feature, and not just a bug fix? |
👍 Sounds good to me |
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | minor | `v6.2.0` -> `v6.3.2` |---### Release Notes<details><summary>actions/github-script</summary>###[`v6.3.2`](https://togithub.com/actions/github-script/releases/tag/v6.3.2)[CompareSource](https://togithub.com/actions/github-script/compare/v6.3.1...v6.3.2)##### What's Changed- Update [@​actions/core](https://togithub.com/actions/core) to1.10.0 by [@​rentziass](https://togithub.com/rentziass) in[https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295)##### New Contributors- [@​rentziass](https://togithub.com/rentziass) made their firstcontribution in[https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295)**Full Changelog**:actions/github-script@v6.3.1...v6.3.2###[`v6.3.1`](https://togithub.com/actions/github-script/releases/tag/v6.3.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.3.0...v6.3.1)#### What's Changed- Fix overriding request options from[@​actions/github](https://togithub.com/actions/github) by[@​luketomlinson](https://togithub.com/luketomlinson) in[https://github.com/actions/github-script/pull/293](https://togithub.com/actions/github-script/pull/293)**Full Changelog**:actions/github-script@v6.3.0...v6.3.1###[`v6.3.0`](https://togithub.com/actions/github-script/releases/tag/v6.3.0)[CompareSource](https://togithub.com/actions/github-script/compare/v6.2.0...v6.3.0)#### What's Changed- Add retry plugin and related options by[@​luketomlinson](https://togithub.com/luketomlinson) in[https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288),seehttps://github.com/actions/github-script/tree/v6.3.0#retries formore information.#### New Contributors- [@​luketomlinson](https://togithub.com/luketomlinson) made theirfirst contribution in[https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288)**Full Changelog**:actions/github-script@v6.2.0...v6.3.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, clickthis checkbox.---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMi4wIn0=-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a few new features:
retries
: the number of times to retry a failed requestretryAfter
: a delay after retryingdoNotRetry
: a list of HTTP status codes to NOT retryThese options largely mirror the options from the octokit plugin.
These options are completely opt in and require you to be explicit:
retryAfter
anddoNotRetry
will have no effect unlessretries
is set.fixes#104