Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add retry plugin and related options#288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joshmgross merged 11 commits intoactions:mainfromluketomlinson:main
Sep 26, 2022

Conversation

luketomlinson
Copy link
Contributor

@luketomlinsonluketomlinson commentedSep 23, 2022
edited
Loading

This PR adds a few new features:

  • Support foroctokit/plugin-retry.js
  • 3 new options
    • retries: the number of times to retry a failed request
    • retryAfter: a delay after retrying
    • doNotRetry: a list of HTTP status codes to NOT retry

These options largely mirror the options from the octokit plugin.

These options are completely opt in and require you to be explicit:retryAfter anddoNotRetry will have no effect unlessretries is set.

fixes#104

@luketomlinsonluketomlinson requested a review froma teamSeptember 23, 2022 15:57
Copy link
Member

@joshmgrossjoshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you bump the version to6.2.1 inpackage.json?

retries
}

core.info(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should this be debug?
Users might not want every step to output this information

luketomlinson reacted with thumbs up emoji
@luketomlinson
Copy link
ContributorAuthor

@joshmgross what do you think about 6.3.0 since this is adding a feature, and not just a bug fix?

@joshmgross
Copy link
Member

@joshmgross what do you think about 6.3.0 since this is adding a feature, and not just a bug fix?

👍 Sounds good to me

@joshmgrossjoshmgross merged commitd4560e1 intoactions:mainSep 26, 2022
fuxingloh referenced this pull request in DeFiCh/metachainOct 12, 2022
[![MendRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/github-script](https://togithub.com/actions/github-script) |action | minor | `v6.2.0` -> `v6.3.2` |---### Release Notes<details><summary>actions/github-script</summary>###[`v6.3.2`](https://togithub.com/actions/github-script/releases/tag/v6.3.2)[CompareSource](https://togithub.com/actions/github-script/compare/v6.3.1...v6.3.2)##### What's Changed- Update [@&#8203;actions/core](https://togithub.com/actions/core) to1.10.0 by [@&#8203;rentziass](https://togithub.com/rentziass) in[https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295)##### New Contributors- [@&#8203;rentziass](https://togithub.com/rentziass) made their firstcontribution in[https://github.com/actions/github-script/pull/295](https://togithub.com/actions/github-script/pull/295)**Full Changelog**:actions/github-script@v6.3.1...v6.3.2###[`v6.3.1`](https://togithub.com/actions/github-script/releases/tag/v6.3.1)[CompareSource](https://togithub.com/actions/github-script/compare/v6.3.0...v6.3.1)#### What's Changed- Fix overriding request options from[@&#8203;actions/github](https://togithub.com/actions/github) by[@&#8203;luketomlinson](https://togithub.com/luketomlinson) in[https://github.com/actions/github-script/pull/293](https://togithub.com/actions/github-script/pull/293)**Full Changelog**:actions/github-script@v6.3.0...v6.3.1###[`v6.3.0`](https://togithub.com/actions/github-script/releases/tag/v6.3.0)[CompareSource](https://togithub.com/actions/github-script/compare/v6.2.0...v6.3.0)#### What's Changed- Add retry plugin and related options by[@&#8203;luketomlinson](https://togithub.com/luketomlinson) in[https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288),seehttps://github.com/actions/github-script/tree/v6.3.0#retries formore information.#### New Contributors- [@&#8203;luketomlinson](https://togithub.com/luketomlinson) made theirfirst contribution in[https://github.com/actions/github-script/pull/288](https://togithub.com/actions/github-script/pull/288)**Full Changelog**:actions/github-script@v6.2.0...v6.3.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, clickthis checkbox.---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMi4wIn0=-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hashtagchrishashtagchrishashtagchris left review comments

@joshmgrossjoshmgrossjoshmgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please consider retries for the Octokit client
3 participants
@luketomlinson@joshmgross@hashtagchris

[8]ページ先頭

©2009-2025 Movatter.jp