Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Only search cwd on user-script require calls#136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jclem merged 3 commits intomainfromsearch-cwd-first
Apr 21, 2021
Merged

Conversation

jclem
Copy link
Contributor

@jclemjclem commentedApr 21, 2021
edited
Loading

Currently, we search the existingmodule.paths andthenprocess.cwd() when a user script callsrequire. Instead, we should remove the fallback altogether (since at runtime, the actions/github-script directory has no modules installed, anyway), and only searchprocess.cwd().

This can be a patch release once merged.

Thanks@JamesMGreenefor reporting.

JamesMGreene reacted with heart emoji
@jclemjclem requested a review froma teamApril 21, 2021 22:14
@jclemjclem changed the titleSearch the cwd first, then existing module pathsOnly search cwd on user-script require callsApr 21, 2021
@github-actions
Copy link

github-actionsbot commentedApr 21, 2021
edited
Loading

Hello from actions/github-script! (eb39546)

@jclemjclem merged commit85e88a6 intomainApr 21, 2021
@jclemjclem deleted the search-cwd-first branchApril 21, 2021 22:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@joshmgrossjoshmgrossjoshmgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jclem@joshmgross

[8]ページ先頭

©2009-2025 Movatter.jp