@robyoung could this break existing uses of this action that assume the requireisn't relative?

Not that I can think of if they assume the require isn't relative. If an absolute path is provided it still works as expected because in those cases the current working directory is irrelevant.

Uses that depend on whatever the current working directory is now would break (assuming that is different toGITHUB_WORKSPACE) but I think that's ok as it's explicitly unsupported in the README.

@joshmgross is there anything else you need before this can be merged?

👋 Hey@robyoung, sorry for the delay. I'll try to test this out next week and get it merged.

Just rebased to resolve a conflict with the updated version. Any idea when this may get reviewed@joshmgross

👋 Hey@robyoung, apologies again for the delay. The changes look good to me but I need to run through a few test scenarios to make sure we're not breaking any existing uses.

Unfortunately, relative requires not working isn't because of the working directory (actions run by default in theGITHUB_WORKSPACE, as it is). Instead, it's becauserequire resolves paths relative to the module—in this case, the module location is where theactions/github-script action was downloaded to on the runner.

This is why although tests pass in this fork, calls torequire relative to the workspace still will not function. We're still searching for a way to resolve this.

I'm going to close this issue, but@robyoung please feel free to follow up if you have any other questions!

#135 should fix this

Edit: Published in V4https://github.com/actions/github-script/releases/tag/v4.0.0