- Notifications
You must be signed in to change notification settings - Fork10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Adding golang/dep#30
base:master
Are you sure you want to change the base?
Conversation
coveralls commentedSep 19, 2017
Hi@nmengin, thank you for the PR! I tried to avoid using any dependency management on the libkv side because I think it is better handled on the side of projects using the library (using dep/glide/godep/etc.). It is true that this is annoying because of occasional breakage of client libraries (for example recently with I'm not against including this change but I'm not sure this is entirely necessary either (considering the small scale of the project). Thoughts? |
Also it's broken on the CI somehow. |
Ok@abronan. I just did it in the way to compile the master branch and submit you PR about ETCD management. |
Adding the new toolgolang/dep for the libkv project.
This tool allows dependencies management.
Fix versions for dependencies as
constraintsoroverrideswhen necessary.