- Notifications
You must be signed in to change notification settings - Fork3.6k
Fixed misleading parameter variable names of ReverseMap methods.#24266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ejohnson-dotnet wants to merge2 commits intoabpframework:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The ReverseMap methods will map the destination type back to the source type, but the "source" object will be of type TDestination. In other words, the "TDestination source" object is copied to the "TSource destination" object.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## dev #24266 +/- ##==========================================- Coverage 51.07% 51.06% -0.01%========================================== Files 3288 3288 Lines 107052 107061 +9 Branches 8221 8223 +2 ==========================================- Hits 54677 54675 -2- Misses 50692 50701 +9- Partials 1683 1685 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ReverseMap methods will map the destination type back to the source type, but the "source" object will be of type TDestination. In other words, the "TDestination source" object is copied to the "TSource destination" object.
Description
Resolves#24265
This fixes the misleading parameter names to make clear which is the source object and which is the destination object.
This file already has the parameter names correctly implemented.
modules/identityserver/src/Volo.Abp.IdentityServer.Domain/Volo/Abp/IdentityServer/IdentityServerMapperlyMappers.cs
Checklist
How to test it?
Please describe how this can be tested by the test engineers if it is not already explicit - or remove this section if no need to description.