- Notifications
You must be signed in to change notification settings - Fork161
C++ mangled name support in Kernel#2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
python/iron/kernel.py Outdated
| """ | ||
| self._name=name | ||
| symbol_name=find_mangled_symbol(f"build/{bin_name}",name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I need to figure out how to get the actual .o path here, it's just the name and then it happens to work during linking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think there is a general implicit assumption that theprogramming_examples/basic/vector_reduce_min/vector_reduce_min.py file is called within the build dir.
ypapadop-amdAug 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good call.aiecc.py is called in the build directory which does the linking, but the MLIR generation happens earlier. I currently need the object file earlier, unless I defer mangling until linking (which it would be the preferred approach).
Generating MLIR while in thebuild directory allows it to work correctly.
39e2847 toeefb7c3CompareCo-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ypapadop-amd commentedAug 7, 2025
Maybe this would be better as an MLIR pass? |
No description provided.