- Notifications
You must be signed in to change notification settings - Fork281
[Streamline] Allow AbsorbSignBiasIntoMultiThreshold to absorb any bias#1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
iksnagreb wants to merge6 commits intoXilinx:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[Streamline] Allow AbsorbSignBiasIntoMultiThreshold to absorb any bias#1173
iksnagreb wants to merge6 commits intoXilinx:devfromiksnagreb:feature/absorb-bias-into-multithreshold
+131 −48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Note: Keep the name indicating only handling signed-bias but adjust thedatatype inference after absorbing the bias to handle signed bias aswell as outputs.
Adds more (proably too much) code documentation and more usefulewarnings instead of a single hard assertion failure...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Keep the name indicating only handling signed-bias but adjust the datatype inference after absorbing the bias to handle signed bias as well as outputs.
Draft PR for now, related to work on streamlining for more generalized activation function support via multi-thresholds, but this could be of interest in any situation where it is easier to move some bias (not just the exported sign-bias but any scalar
Add) upwards instead of downwards through the graph, e.g., if there is some joiningMulorMatMuloperation blocking the usual flow of streamlining transformation.