- Notifications
You must be signed in to change notification settings - Fork1.3k
proton: Populate NVIDIA_WINE_DLL_DIR when available#8087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
liam-middlebrook wants to merge2 commits intoValveSoftware:experimental_9.0Choose a base branch
base:experimental_9.0
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
proton: Populate NVIDIA_WINE_DLL_DIR when available#8087
liam-middlebrook wants to merge2 commits intoValveSoftware:experimental_9.0fromliam-middlebrook:lmiddlebrook/nvidia-wine-dll-dir-env
+22 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Plagman pushed a commit that referenced this pull requestSep 10, 2024
NVIDIA-software may check the environment variable `NVIDIA_WINE_DLL_DIR`for a path where DLLs provided by the NVIDIA Linux driver can be found.This needs to be set by `proton` script, as it is ran inside of thepressure-vessel environment, so the paths returned will be valid withinthe environment.Tested with an application that reads `NVIDIA_WINE_DLL_DIR` from theenvironment and tries to load a known DLL from it. As expected manuallysetting the environment variable to the on-disk location did not work,as the path is not accurate within the pressure-vessel environment.#8087
adamdmoss approved these changesSep 16, 2024
adamdmoss left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For what my ex-nvidia-employee opinion is worth: LGTM. I infer from the lack of specifics (and not privileged knowledge) that this is to enable some future tech work, but if there is an existing title which needs this then pointing it out would be good for verification purposes.
ContributorAuthor
liam-middlebrook commentedSep 17, 2024
Noting from a side-discussion between myself@ivyl, pgofman, and zf. This environment variable isn't ideal because it creates wine/proton specific behavior. Since the way this would be read on Windows isn't currently supported in Wine, this environment variable will only be read as a fallback. That way, in the future if the primary path is supported, this logic could be removed. In the meantime there's some cleanup things to do here (like avoiding running through the C_DLL logic twice). |
NVIDIA-software may check the environment variable `NVIDIA_WINE_DLL_DIR`for a path where DLLs provided by the NVIDIA Linux driver can be found.This is done as a fallback for when the "DriverStore" cannot be detectedvia the D3DDDI functions for querying an adapter-specific registry key.Tested with an application that reads `NVIDIA_WINE_DLL_DIR` from theenvironment and tries to load a known DLL from it. As expected manuallysetting the environment variable to the on-disk location did not work,as the path is not accurate within the pressure-vessel environment.
34e90a8 tod380d66Compare124cdc3 to2a4943dComparevinifmor pushed a commit to vinifmor/Proton that referenced this pull requestOct 3, 2024
NVIDIA-software may check the environment variable `NVIDIA_WINE_DLL_DIR`for a path where DLLs provided by the NVIDIA Linux driver can be found.This needs to be set by `proton` script, as it is ran inside of thepressure-vessel environment, so the paths returned will be valid withinthe environment.Tested with an application that reads `NVIDIA_WINE_DLL_DIR` from theenvironment and tries to load a known DLL from it. As expected manuallysetting the environment variable to the on-disk location did not work,as the path is not accurate within the pressure-vessel environment.ValveSoftware#8087
5d2111a to7f6b0ffComparePlagman pushed a commit that referenced this pull requestNov 6, 2024
NVIDIA-software may check the environment variable `NVIDIA_WINE_DLL_DIR`for a path where DLLs provided by the NVIDIA Linux driver can be found.This is done as a fallback for when the "DriverStore" cannot be detectedvia the D3DDDI functions for querying an adapter-specific registry key.Tested with an application that reads `NVIDIA_WINE_DLL_DIR` from theenvironment and tries to load a known DLL from it. As expected manuallysetting the environment variable to the on-disk location did not work,as the path is not accurate within the pressure-vessel environment.Link:#8087
Plagman pushed a commit that referenced this pull requestNov 27, 2024
NVIDIA-software may check the environment variable `NVIDIA_WINE_DLL_DIR`for a path where DLLs provided by the NVIDIA Linux driver can be found.This is done as a fallback for when the "DriverStore" cannot be detectedvia the D3DDDI functions for querying an adapter-specific registry key.Tested with an application that reads `NVIDIA_WINE_DLL_DIR` from theenvironment and tries to load a known DLL from it. As expected manuallysetting the environment variable to the on-disk location did not work,as the path is not accurate within the pressure-vessel environment.Link:#8087
1753216 todcf29c3CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVIDIA-software may check the environment variable
NVIDIA_WINE_DLL_DIRfor a path where DLLs provided by the NVIDIA Linux driver can be found. This needs to be set byprotonscript, as it is ran inside of the pressure-vessel environment, so the paths returned will be valid within the environment.Tested with an application that reads
NVIDIA_WINE_DLL_DIRfrom the environment and tries to load a known DLL from it. As expected manually setting the environment variable to the on-disk location did not work, as the path is not accurate within the pressure-vessel environment.