- Notifications
You must be signed in to change notification settings - Fork1.3k
Add CPU core limit for PW: AAT#8008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Tiagoquix wants to merge75 commits intoValveSoftware:bleeding-edgeChoose a base branch
base:bleeding-edge
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
First, and only on this list so far is Guild Wars 2 (1284210)CW-Bug-Id: #23824
CW-Bug-Id: #23808SteamAppId isn't set for InstallScripts, but this variable is.
This reverts commita090d16.
To keep SDL 2.30 old behavior until we start supporting it.CW-Bug-Id: #23185
CW-Bug-Id: #23185
In some cases, wget -O will create the file even when thedownload fails. This is not removed by make and will makesubsequent failures more confusing, as well as failing torecover if the cause was an intermittent network failure.
These files are copied into lib(64)/wine/dxvk with user-writepermission, which is later removed by default_pfx: rule.Hence failing to 'cp' upon update.
…numerateSwapchainImages.
…ack_message_utow even if Unix len is unknown.CW-Bug-Id: #23875
CW-Bug-Id: #23874
CW-Bug-Id: #22421
No-op but make_specfiles reads .specs and make_vulkan updates one.
CW-Bug-Id: #23916
CW-Bug-Id: #23924
That path can be relative when the build directory is inside the Protonsource directory. Since it then used to patch compile_commands.json, itis important that it is absolute, otherwise it implicitly becomes graftedto a directory for which it is meaningless.
CW-Bug-Id: #23962
CW-Bug-Id: #23962
1d19aa2 to656b468CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See#3324 (comment).
I'm unable to test this fix because my CPU doesn't have that many cores, but this fix should be fine. Maybe limit it to less just to be even safer (12 or 8). The recommended CPU for this game has 4 cores (https://ark.intel.com/content/www/us/en/ark/products/65702/intel-core-i5-3570-processor-6m-cache-up-to-3-80-ghz.html).