Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix for ValveSoftware/Proton/#4269#4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gitaen wants to merge1 commit intoValveSoftware:proton_5.13
base:proton_5.13
Choose a base branch
Loading
fromgitaen:proton_5.13

Conversation

@gitaen
Copy link

symlinks copied to pfx directory were using wrong relative paths

     ./pfx/drive_c/windows/syswow64/kernel32.dll -> dist/lib/wine/fakedlls/kernel32.dll

fixed to use absolute path

adojck, Axeltherabbit, fabianhjr, TheBlackParrot, tri2820, Vanadiom, LiveLM, Weirdo1312, owl-from-hogvarts, kuator, and 4 more reacted with thumbs up emoji
symlinks copied to pfx directory were using wrong relative paths         ./pfx/drive_c/windows/syswow64/kernel32.dll -> dist/lib/wine/fakedlls/kernel32.dllfixed to use absolute path
@aeikum
Copy link
Collaborator

Hmm. I'm not necessarily opposed to this, but I think it shouldn't be necessary. The src argument to that function should be a full path, since Steam launches Proton with a full path. How are you launching Proton so it gets in this state?

@gitaen
Copy link
Author

I am launching it with
STEAM_COMPAT_DATA_PATH=/tmp/proton_data ./proton run binary.exe

zaps166, fabianhjr, F1xteR, kuator, and YoreonX reacted with thumbs up emoji

@F1xteR
Copy link

Even with the fix applied Proton 5.13-4 still won't launch, same error code.
Did i do something wrong? i applied the fix in the Proton python file and deleted pfx, pycache and dist folders.
I also launched it like above just setting STEAM_COMPAT_DATA_PATH to steamapps/common/Proton 5.13

@ghost
Copy link

@F1xteR STEAM_COMPAT_DATA_PATH should be set to the directory where your pfx wineprefix will be. I set it to $HOME/proton

@opl-
Copy link

opl- commentedJan 9, 2021
edited
Loading

In order for this fix to work, you will need to create a newcompatdata directory (wine prefix) for the game that's crashing. This is because the issue exists within the code that initializes it which won't run if one already exists.

Step by step instructions (for Steam users):

  1. Apply this patch (for example by manually editing theSteamLibrary/steamapps/common/Proton 5.13/proton file to applythe change).
  2. Find out the app ID of the crashing game throughSteamDB or (in Steam beta versions) by right clicking it in the Steam library, opening the Properties window and looking in the bottom left corner.
  3. Go toSteamLibrary/steamapps/compatdata/, rename the directory named after the app ID from step 2 and create a new, empty directory in its place.
    • This directory might contain your saves or other user data. It includes directories such as App Data and Documents. Make sure to backup any important files before deleting it.
  4. Run the game from your Steam library. The empty directory should now contain a fresh wine prefix.
  5. If needed, copy any saves or other user data you need from the old, renamed directory into the newcompatdata directory and verify that it worked. After that the old, renamed directory can be deleted.

@nyabinary
Copy link

Why did this never get merged?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@Frigyes06Frigyes06Frigyes06 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gitaen@aeikum@F1xteR@opl-@nyabinary@Frigyes06

[8]ページ先頭

©2009-2025 Movatter.jp