Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove some ts-expect-error and coveralls dependency#787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gastonfournier merged 3 commits intomainfromremove-ts-expect-error
Nov 26, 2025

Conversation

@gastonfournier
Copy link
Contributor

@gastonfourniergastonfournier commentedNov 26, 2025•
edited
Loading

About the changes

Try to make our dev life easier by removing unnecessary// @ts-expect-error that might be hiding real problems

Also, remove coveralls, which keep the request library pinned:

coveralls@3.1.1 requires form-data@~2.3.2 via a transitive dependency on request@2.88.2

@coveralls
Copy link

coveralls commentedNov 26, 2025•
edited
Loading

Pull Request Test Coverage Report forBuild 19712494976

Details

  • 0 of0 changed or added relevant lines in0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to90.178%
TotalsCoverage Status
Change from baseBuild 19530984049:-0.05%
Covered Lines:1276
Relevant Lines:1354
💛 -Coveralls


repo.once('error',(err)=>{
t.truthy(err);
repo.stop();
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needed to resolve unhandled promises

@gastonfourniergastonfournier changed the titlechore: remove ts-expect-errorchore: remove some ts-expect-error and coveralls dependencyNov 26, 2025
@gastonfourniergastonfournier self-assigned thisNov 26, 2025
Copy link
Member

@nunogoisnunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agreed 👍

@github-project-automationgithub-project-automationbot moved this fromNew toApproved PRs inIssues and PRsNov 26, 2025
@gastonfourniergastonfournier merged commit2773f4b intomainNov 26, 2025
5 checks passed
@gastonfourniergastonfournier deleted the remove-ts-expect-error branchNovember 26, 2025 19:18
@github-project-automationgithub-project-automationbot moved this fromApproved PRs toDone inIssues and PRsNov 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nunogoisnunogoisnunogois approved these changes

Assignees

@gastonfourniergastonfournier

Labels

None yet

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gastonfournier@coveralls@nunogois
[8]ページ先頭
©2009-2025 Movatter.jp