- Notifications
You must be signed in to change notification settings - Fork71
fix: also reduce back off counter for 304#772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coveralls commentedOct 29, 2025
Pull Request Test Coverage Report forBuild 18907607420Details
💛 -Coveralls |
| }); | ||
| if(res.status===304){ | ||
| this.emit(UnleashEvents.Unchanged); | ||
| nextFetch=this.countSuccess(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
worth checking if we have tests for 200 recover and add one for 304 recovery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we do not.
88a6133 intomainUh oh!
There was an error while loading.Please reload this page.
304 responses are successful (server indicates cache is valid) but weren't calling
countSuccess()to reduce the failure counter. This fix ensures both 304 and 200 responses contribute to backoff recovery, preventing the failure counter from remaining elevated during periods of unchanged flags.