- Notifications
You must be signed in to change notification settings - Fork4.4k
Pettingzoo wrapper changed to gymnasium interface#6211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
alexander-zap wants to merge11 commits intoUnity-Technologies:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Pettingzoo wrapper changed to gymnasium interface#6211
alexander-zap wants to merge11 commits intoUnity-Technologies:developfromalexander-zap:pettingzoo_gymnasium_support
+311 −116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- added dependency to gymnasium instead of gym- adjusted Unity gym interface to return `truncated` on step- adjusted Unity gym interface to accept `seed` and `options` on reset (not used)- adjusted Unity gym interface to not accept `mode` on reset (not used anyway)- relaxed dependencies to numpy, pettingzoo and Python version
…(without publishing)
Local poetry support
…t returning obs and info; step returning terminated and truncated instead of done)
CLAassistant commentedJun 13, 2025
a_zap seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let usrecheck it. |
…t returning obs and info; step returning terminated and truncated instead of done)
- all agents return an observations synchronously (instead of having steps where only one agent returns an observation)- in case the agent sends a TerminationStep *and* a DecisionStep after, the reward from the termination step should be taken (but for observations it's the other way around because of SB3 convention)- `agents` attribute should store agents even if they have *just* finished (they should be removed the step after)- fixed a bug where a continuous action vector was assigned len(action) * action[0]- fixed double removal of an agent from _live_agents for ParallelEnv
Author
alexander-zap commentedJun 30, 2025
Should also solve#6214 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Proposed change(s)
I adjusted the Unity Pettingzoo Wrapper to support the gymnasium interface (gymnasium>=0.25).
This includes:
terminated, truncatedon stepinfoon resetseedandoptionson resetmodeon renderAdditionall, I fixed interface problems with pettingzoo implementation:
agentsattribute should store agents even if they havejust finished (they should be removed the step after)Also I bumped the dependencies for pettingzoo to 1.22.0 (because this is there Gymnasium support started on their side).
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
This also could be helpful for:#5890
Types of change(s)
Checklist
Other comments