Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Upgrade Barracuda to 2.3.1-preview#5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hvpeteet merged 2 commits intomainfromdevelop-barracuda-2.3.0-preview
Oct 27, 2021

Conversation

@hvpeteet
Copy link
Contributor

@hvpeteethvpeteet commentedOct 20, 2021•
edited
Loading

Proposed change(s)

Upgrade Barracuda references to 2.3.1-preview

Used#5291#5305#5343 as references.

⚠️ This is my first time doing thisPLEASE TRIPPLE CHECK

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Internal JIRA:https://jira.unity3d.com/browse/MLA-2253

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other: Upgrade dependency

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated thechangelog (if applicable)
  • Updated thedocumentation (if applicable)
  • Updated themigration guide (if applicable)

Other comments

@hvpeteethvpeteet marked this pull request as ready for reviewOctober 20, 2021 16:15
Copy link
Contributor

@miguelalonsojrmiguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Let's wait until tomorrow to merge to make sure nightly training passes, but otherwise, should be good to go.

Copy link
Contributor

@maryamhonarimaryamhonari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@hvpeteet
Copy link
ContributorAuthor

Running some CI jobs manually. Will merge before official CI kicks off today

@hvpeteethvpeteet changed the titleUpgrade Barracuda to 2.3.0-previewUpgrade Barracuda to 2.3.1-previewOct 27, 2021
2.3.0-preview had a bug that was fixed. See JIRA ticket.
@hvpeteet
Copy link
ContributorAuthor

Upgraded to 2.3.1-preview after bug was found in 2.3.0-preview. Seehttps://unity.slack.com/archives/CAFUH1CQN/p1635265775006100

@hvpeteet
Copy link
ContributorAuthor

Ran some experiments with inference and they finished (unlike with 2.3.0).

@hvpeteethvpeteet merged commitbf3649f intomainOct 27, 2021
@delete-merged-branchdelete-merged-branchbot deleted the develop-barracuda-2.3.0-preview branchOctober 27, 2021 15:15
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@maryamhonarimaryamhonarimaryamhonari approved these changes

@miguelalonsojrmiguelalonsojrmiguelalonsojr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hvpeteet@maryamhonari@miguelalonsojr
[8]ページ先頭
©2009-2025 Movatter.jp