Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

attempt at removing uielements dependency#2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
LeoUnity wants to merge12 commits intodevelop
base:develop
Choose a base branch
Loading
fromleo/uielements-dependency-adjust

Conversation

@LeoUnity
Copy link
Collaborator

Description

Please fill this section with a description what the pull request is trying to address and what changes were made.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change inChanged,Fixed,Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional testsArea_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@codecov-github-com
Copy link

codecov-github-combot commentedSep 25, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is9.86547% with201 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
.../Actions/Interactions/MultiTapInteractionEditor.cs0.00%29 Missing⚠️
...tor/Actions/Interactions/PressInteractionEditor.cs0.00%24 Missing⚠️
...Controls/Processors/AxisDeadzoneProcessorEditor.cs0.00%17 Missing⚠️
...ontrols/Processors/StickDeadzoneProcessorEditor.cs0.00%17 Missing⚠️
...r/Actions/Interactions/SlowTapInteractionEditor.cs0.00%16 Missing⚠️
...ditor/Actions/Interactions/TapInteractionEditor.cs0.00%16 Missing⚠️
...itor/Actions/Interactions/HoldInteractionEditor.cs0.00%15 Missing⚠️
....inputsystem/Editor/Actions/AxisCompositeEditor.cs0.00%14 Missing⚠️
...putsystem/Editor/Actions/Vector2CompositeEditor.cs0.00%14 Missing⚠️
...putsystem/Editor/Actions/Vector3CompositeEditor.cs0.00%14 Missing⚠️
... and5 more
@@             Coverage Diff             @@##           develop    #2243      +/-   ##===========================================+ Coverage    68.14%   72.14%   +3.99%===========================================  Files          367      550     +183       Lines        53685    98126   +44441     ===========================================+ Hits         36584    70793   +34209- Misses       17101    27333   +10232
FlagCoverage Δ
inputsystem_MacOS_6000.36.43% <12.50%> (?)

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...sts/InputSystem.Editor/ControlSchemeEditorTests.cs100.00% <100.00%> (ø)
Assets/Tests/InputSystem/CoreTests_Editor.cs97.70% <ø> (ø)
...stem/Editor/AssetEditor/InputActionAssetManager.cs66.39% <ø> (ø)
...tem/Editor/AssetEditor/InputActionEditorToolbar.cs0.00% <ø> (ø)
...stem/Editor/AssetEditor/InputActionEditorWindow.cs0.00% <ø> (ø)
...em/Editor/AssetEditor/InputActionPropertiesView.cs0.00% <ø> (ø)
...utsystem/Editor/AssetEditor/InputActionTreeView.cs50.20% <100.00%> (ø)
...tem/Editor/AssetEditor/InputActionTreeViewItems.cs74.91% <ø> (ø)
...m/Editor/AssetEditor/InputBindingPropertiesView.cs0.00% <ø> (ø)
...tem/Editor/AssetEditor/NameAndParameterListView.cs0.00% <ø> (ø)
... and93 more

... and98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekcoh
Copy link
Collaborator

@LeoUnity Please update this branch with latest changes from develop to get critical changes from#2260. I do not dare doing it since branch has conflicts I may not understand.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LeoUnity@ekcoh

[8]ページ先頭

©2009-2025 Movatter.jp