Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Prevent SDL layouts from being created if a layout already exists#1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jgcodes2020 wants to merge2 commits intoUnity-Technologies:develop
base:develop
Choose a base branch
Loading
fromjgcodes2020:develop

Conversation

@jgcodes2020
Copy link

Description

Unity's HID layout generator does not generate a layout if one already exists. I added this functionality to the Linux/SDL layout generator.

Changes made

Added a check to the SDL layout generator, preventing it from generating a layout if one exists already.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change inChanged,Fixed,Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" withnext release version correctly set.
  • Tests added/changed, if applicable.
    • Functional testsArea_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@unity-cla-assistant
Copy link

unity-cla-assistant commentedMay 12, 2024•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ekcohekcoh added the waiting-for-reviewThe issue is scheduled to be reviewed by the Unity maintainers labelMay 14, 2024
@jgcodes2020jgcodes2020 marked this pull request as ready for reviewMay 14, 2024 12:55
Copy link
Collaborator

@ekcohekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to prevent layout generation if a matching layout already exists. Thanks for the contribution.

@ekcohekcoh removed the waiting-for-reviewThe issue is scheduled to be reviewed by the Unity maintainers labelSep 13, 2024
@ekcoh
Copy link
Collaborator

Branch needs to be updated with changes from develop before it may be subject for QA and potential merge.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ekcohekcohekcoh left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgcodes2020@unity-cla-assistant@ekcoh
[8]ページ先頭
©2009-2025 Movatter.jp