- Notifications
You must be signed in to change notification settings - Fork45
Stricter check for enum classes in EnumModelProvider #558#559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-author: volivan239Anonymous inner classes declared for enum constants are not enumsthemselves, as the necessary condition for being enums is that theirdirect supertype is `java.lang.Enum` (see the JavaDoc and comments of`java.lang.Class#isEnum` method). For these classes, `getEnumConstants`method returns `null`.
Markoutte approved these changesJul 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-author:@volivan239
Description
Java enums allow users to declare anonymous classes corresponding to constants. These classes are commonly used to overload
toStringor methods declared in the enum class. These classes are not enums themselves. According to the comment in thejava.lang.Class#isEnummethod:Suppose we have an enum:
Anonymous inner classes
Foo$1andFoo$2are (non-direct) subtypes ofjava.lang.Enum, but are not declared as enums, and are not considered enums from the point of view of the Java specification: their direct superclass isFoo.These specialized anonymous classes do not have enum constants themselves, and
getEnumConstantsmethod will returnnullfor them.Fixes#558
Type of Change
How Has This Been Tested?
Automated Testing
No new unit tests are added. All existing tests should pass.
Manual Scenario
Run the contest estimator on
com.google.common.base.CaseFormatclass of the Guava library by editingmainfunction body inContestEstimator.kt:Tests (probably with errors due to other issues) should be generated. Without the fix, a
NullPointerExceptionwould be thrown, and no tests would be generated.Checklist: