Fix possible NPE for package name in rarely cases#544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Jul 18, 2022

Merged

Jul 18, 2022

Conversation

Copy link

Collaborator

In some casesClass#getPackage can return null. This should fix these cases.

The change followed the style guidelines of the UTBot project
Self-review of the code is passed
The change contains enough commentaries, particularly in hard-to-understand areas
New documentation is provided or existed one is altered
No new warnings
Tests that prove my change is effective
All tests pass locally with my changes

Fix possible NPE for package name in rarely cases

a3f2e8e

Markoutte requested a review fromdtim

dtim approved these changes

Copy link

Collaborator

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but it would be nice to have some comments as the logic becomes not so clear as before.

		privatefunisAccessible(member:Member,packageName:String?):Boolean {
		return isPublic(member.modifiers)\|\|
		(isPackagePrivate(member.modifiers)&& member.declaringClass.`package`.name== packageName)
		(packageName!=null&&isPackagePrivate(member.modifiers)&& member.declaringClass.`package`?.name== packageName)