Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change private expectedResult type to Object in generated parametrized tests #528#529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EgorkaKulikov merged 1 commit intomainfromandrey-t/private-class-access-problem
Jul 15, 2022

Conversation

@sofurihafe
Copy link
Member

Description

Type of aexpectedResult isClassWithStaticAndInnerClasses.PrivateStaticClassWithPrivateField which is private in a superclass. Now we useObject type for private classes in parametrized test generation.

Fixes # (528)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

Runutbot-samples pipeline with parametrized tests generation.

Manual Scenario

Generate parametrized test forVoidStaticMethodsTest fromutbot-samples. Verify that there isObject instead ofClassWithStaticAndInnerClasses.PrivateInnerClassWithPrivateField type.

@sofurihafesofurihafe linked an issueJul 15, 2022 that may beclosed by this pull request
@EgorkaKulikovEgorkaKulikov self-requested a reviewJuly 15, 2022 06:42
@EgorkaKulikovEgorkaKulikov marked this pull request as draftJuly 15, 2022 08:22
@EgorkaKulikovEgorkaKulikov marked this pull request as ready for reviewJuly 15, 2022 10:26
@EgorkaKulikovEgorkaKulikov marked this pull request as draftJuly 15, 2022 11:43
@sofurihafesofurihafeforce-pushed theandrey-t/private-class-access-problem branch frome81dcc2 to77c4d13CompareJuly 15, 2022 11:48
@sofurihafesofurihafe requested a review fromDamtevJuly 15, 2022 11:56
@EgorkaKulikovEgorkaKulikov marked this pull request as ready for reviewJuly 15, 2022 13:35
@EgorkaKulikovEgorkaKulikovenabled auto-merge (squash)July 15, 2022 13:36
@EgorkaKulikovEgorkaKulikov merged commitd5d7ea5 intomainJul 15, 2022
@EgorkaKulikovEgorkaKulikov deleted the andrey-t/private-class-access-problem branchJuly 15, 2022 13:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@EgorkaKulikovEgorkaKulikovEgorkaKulikov approved these changes

@DamtevDamtevDamtev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generated code tries to use private class as a type

4 participants

@sofurihafe@EgorkaKulikov@Damtev
[8]ページ先頭
©2009-2025 Movatter.jp