NotificationsYou must be signed in to change notification settings
Fork45
Star142

Disabled tests for autogenerated functions #457#505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

volivan239 merged 1 commit intomainfromvolivan239/disable-tests-for-autogenerated

Jul 18, 2022

Merged

Disabled tests for autogenerated functions #457#505

volivan239 merged 1 commit intomainfromvolivan239/disable-tests-for-autogenerated

Jul 18, 2022

Conversation

Copy link

Collaborator

volivan239 commentedJul 12, 2022•
edited
Loading

Description

Disabled tests for autogenerated methods (values, valueOf) for enum classes.
Fixes#457

Type of Change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

No new tests currently added (in progress)

Manual Scenario

Launch plugin on empty enum class -- it will suppose no methods to generate test, as expected
Launch contest estimator oncom.google.common.base.CaseFormat.* -- it will no more generate tests forvalues andvalueOf.

Checklist (remove irrelevant options):

The change followed the style guidelines of the UTBot project
Self-review of the code is passed
The change contains enough commentaries, particularly in hard-to-understand areas
New documentation is provided or existed one is altered
No new warnings
Tests that prove my change is effective
All tests pass locally with my changes

volivan239 requested a review fromdtim

July 12, 2022 15:29

dtim requested changes

Jul 13, 2022

View reviewed changes

Copy link

Collaborator

dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please see the comments.

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt OutdatedShow resolvedHide resolved

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/UtTestsDialogProcessor.kt OutdatedShow resolvedHide resolved

utbot-junit-contest/src/main/kotlin/org/utbot/contest/Contest.kt OutdatedShow resolvedHide resolved

utbot-cli/src/main/kotlin/org/utbot/cli/GenerateTestsCommand.kt OutdatedShow resolvedHide resolved

volivan239 changed the title~~Disabled tests for autogenerated functions~~Disabled tests for autogenerated functions #457

Jul 15, 2022

volivan239 requested a review fromdtim

July 15, 2022 08:24

volivan239 marked this pull request as ready for review

July 15, 2022 08:25

dtim requested changes

Jul 18, 2022

View reviewed changes

Copy link

Collaborator

dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Algorithmically and conceptually the PR is good, but there are some issues with the code organization. I would like also suggest some stylistic changes.