Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Capitalize method names properly#504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
onewhl merged 2 commits intomainfromonewhl/485-method-name-capitalization
Jul 18, 2022

Conversation

@onewhl
Copy link
Member

Description

PR fixes the way UTBot capitalizes method names.
Now it capitalizes all parts of the method name properly.

Fixes#485

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

See tests inSummaryReturnExampleTest.kt, for example,SummaryReturnExampleTest.testCompareChar().
UTBot generated these names before the fix:

        "testCompareChars_NLessThan1"        "testCompareChars_0OfCharactertoCharsiEqualsA" // need to change i -> I, to -> To        "testCompareChars_0OfCharactertoCharsiEqualsB" // need to change i -> I, to -> To        "testCompareChars_0OfCharactertoCharsiNotEqualsB" // need to change i -> I, to ->To

And these names after the fix:

       "testCompareChars_NLessThan1"       "testCompareChars_0OfCharacterToCharsIEqualsA"       "testCompareChars_0OfCharacterToCharsIEqualsB"       "testCompareChars_0OfCharacterToCharsINotEqualsB"

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • Tests that prove my change is effective
  • All tests pass locally with my changes

@onewhlonewhl added the comp-summariesSomething related to the method names, code comments and display names generation labelJul 12, 2022
@onewhlonewhl requested a review fromamandelpieJuly 12, 2022 13:17
@onewhl
Copy link
MemberAuthor

onewhl commentedJul 12, 2022
edited
Loading

I don't know why tests inInnerMockWithFieldExampleTest andMockWithFieldExampleTest fail.
I noticed that it happens in other PRs opened today, so it seems that some other commit in the main branch broke the test.

Copy link
Collaborator

@amandelpieamandelpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please do something with the isLegitSymbolForFunctionName function

@onewhlonewhlforce-pushed theonewhl/485-method-name-capitalization branch from8f32d68 toafdfc4fCompareJuly 18, 2022 09:18
Copy link
Collaborator

@amandelpieamandelpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@onewhlonewhl merged commit3d91def intomainJul 18, 2022
@onewhlonewhl deleted the onewhl/485-method-name-capitalization branchJuly 18, 2022 13:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@amandelpieamandelpieamandelpie approved these changes

Assignees

No one assigned

Labels

comp-summariesSomething related to the method names, code comments and display names generation

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UTBot generates test method names containing a typo

3 participants

@onewhl@amandelpie

[8]ページ先頭

©2009-2025 Movatter.jp