NotificationsYou must be signed in to change notification settings
Fork45
Star142

Add sarif results minimization #490#498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mmvpm merged 5 commits intomainfromideaseeker/sarif_results_minimization

Jul 13, 2022

Merged

Add sarif results minimization #490#498

mmvpm merged 5 commits intomainfromideaseeker/sarif_results_minimization

Jul 13, 2022

Conversation

Copy link

Collaborator

mmvpm commentedJul 12, 2022•
edited
Loading

Description

Minimize the displayed SARIF results.

Now only one result is displayed for one detected error:

Fixes#490

Type of Change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

org.utbot.sarif.SarifReportTest

Manual Scenario

See details in the issue#490

Checklist:

The change followed the style guidelines of the UTBot project
Self-review of the code is passed
The change contains enough commentaries, particularly in hard-to-understand areas
Tests that prove my change is effective
All tests pass locally with my changes

mmvpm force-pushed theideaseeker/sarif_results_minimization branch fromcd10609 toa55f620Compare

July 12, 2022 08:27

mmvpm self-assigned this

Jul 12, 2022

mmvpm requested a review fromsergeypospelov

July 12, 2022 08:30

sergeypospelov requested changes

Jul 12, 2022

View reviewed changes

Copy link

Member

sergeypospelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Everything is OK, but I'd like to see a little bit more tests. Also maybe add some simple clarifying examples of minimization to the commentaries or even to the documentation? (it's just a suggestion)