Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Required libraries can be installed silently #492#494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Vassiliy-Kudryashov
Copy link
Member

Description

Getting rid of all needless Yes/No and OK/Cancel dialogs that dramatically slowdown first time use case

Fixes#492

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual Scenario

Prepare environment with clean config (e.g. no required libraries (JUnit/Mockito etc. in dependencies, empty or absent resources folder) and run tests generation. Single OK click does everything now.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

@Vassiliy-KudryashovVassiliy-Kudryashov linked an issueJul 11, 2022 that may beclosed by this pull request
@Vassiliy-KudryashovVassiliy-Kudryashov requested review fromEgorkaKulikov and removed request fordenis-fokinJuly 12, 2022 07:14
Copy link
Collaborator

@EgorkaKulikovEgorkaKulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should make an extension class be a little more carefully implemented and clear to newcomers.
Also I have two questions not related to code quality.

@EgorkaKulikovEgorkaKulikov self-requested a reviewJuly 18, 2022 05:21
@EgorkaKulikov
Copy link
Collaborator

@alisevych I suggest to test this functionality carefully in different projects (Maven, Gradle, Idea) of different versions. Potential breaking changes.

@alisevych
Copy link
Member

@EgorkaKulikov@Vassiliy-Kudryashov
I've published plugin from this branch as archive and tested it on IDEA Ultimate 2022.1.3

During testing I faced IndexNotReadyException (see#273) almost every time I've tried to generate tests in a manually created folder in IDEA project.
It was thrown on the first UTBot test generation after IDEA restarted.
On the next calls the tests were generated to the new test root correctly.

No other issues found so far.
As@Vassiliy-Kudryashov suggested, merging latest changes from main into this branch can make sense.
So could please notify me after update? I would check some more cases.

@Vassiliy-KudryashovVassiliy-Kudryashovenabled auto-merge (squash)July 20, 2022 09:07
@Vassiliy-KudryashovVassiliy-Kudryashov deleted the Vassiliy-Kudryashov/492-required-libraries-can-be-installed-silently branchJuly 20, 2022 10:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@EgorkaKulikovEgorkaKulikovEgorkaKulikov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Required libraries can be installed silently

4 participants

@Vassiliy-Kudryashov@EgorkaKulikov@alisevych
[8]ページ先頭
©2009-2025 Movatter.jp