Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Provide references to invoked methods in summary#476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
onewhl merged 4 commits intomainfromonewhl/462-links
Jul 18, 2022

Conversation

@onewhl
Copy link
Member

@onewhlonewhl commentedJul 11, 2022•
edited
Loading

Description

Provide references to invoked methods in summary to make it possible to navigate to them by click.
Fixes#462

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

I fixed the tests affected by the change and added them to this PR.

Manual Scenario

I ran the plugin on several code snippets to make sure that the links the plugin shows are correct.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • Tests that prove my change is effective
  • All tests pass locally with my changes

@onewhlonewhl requested a review fromamandelpieJuly 11, 2022 09:25
@onewhlonewhl added the comp-summariesSomething related to the method names, code comments and display names generation labelJul 11, 2022
* to render the reference.
*/
protectedfuninvokeDescription(className:String,methodName:String)="$className::$methodName"//TODO SAT-1311
protectedfuninvokeDescription(className:String,methodName:String,methodParameterTypes:List<Type>):String {
Copy link
Collaborator

@amandelpieamandelpieJul 18, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a simple note for the future (let's cover this functionality with the unit tests located in the summary module itself)
I'm going to merge first test with DBSCAN#345 issue and you could create a ticket to cover it with the unit functionality without test generation from scratch.

I suggest to cover all known builders, it will be easier to see if something broken there. Also you could use UTBot or Fuzzer to generate these unit tests@onewhl

onewhl reacted with thumbs up emoji
Copy link
MemberAuthor

@onewhlonewhlJul 18, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds awesome, I've created a separate ticket for it:#543

Copy link
Collaborator

@amandelpieamandelpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for me

@onewhlonewhl merged commitf5534cd intomainJul 18, 2022
@onewhlonewhl deleted the onewhl/462-links branchJuly 18, 2022 10:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@amandelpieamandelpieamandelpie approved these changes

Assignees

No one assigned

Labels

comp-summariesSomething related to the method names, code comments and display names generation

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide references to invoked methods in summary

3 participants

@onewhl@amandelpie
[8]ページ先頭
©2009-2025 Movatter.jp