- Notifications
You must be signed in to change notification settings - Fork45
Fix the way of setting static final fields#466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
sergeypospelov merged 3 commits intomainfromsergey/fix-the-way-of-setting-static-final-fieldsJul 11, 2022
Merged
Fix the way of setting static final fields#466
sergeypospelov merged 3 commits intomainfromsergey/fix-the-way-of-setting-static-final-fieldsJul 11, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cfe7bc1 to25c7789CompareCaelmBleidd approved these changesJul 11, 2022
Damtev requested changesJul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we really need this dependency on theutbot-sample? Please consider the idea of moving the test class to the "utbot-core" module.
Damtev approved these changesJul 11, 2022
6a6c293 to5c9a78cCompare5c9a78c to1d7d138CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Merged
withAccessibilityandwithRemovedFinalModiferfunction inReflectionUtil.kt, so it won't be possible to get the wrong cached FieldAccessor field, if we use our function.Fixes#458
Type of Change
How Has This Been Tested?
Manual Scenario
RepeatedTo Reproduce section from#458. Tests are successfully generated.
Checklist (remove irrelevant options):