Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minimize exceptions in signature#418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EgorkaKulikov merged 3 commits intomainfromandrey-t/minimize-signature-exceptions
Jul 8, 2022

Conversation

@sofurihafe
Copy link
Member

@sofurihafesofurihafe commentedJul 5, 2022
edited by EgorkaKulikov
Loading

Description

Filters exceptions in test method signature.

Fixes # (344)
Fixes # (250)

Type of Change

Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Automated Testing

Run utbot-samples pipeline.

Manual Scenario

Create a method throwing many exceptions inheriting each other. Verify that only required ones are represented in test signature.

@sofurihafesofurihafe added the comp-codegenIssue is related to code generator labelJul 5, 2022
@sofurihafesofurihafe requested a review fromDamtevJuly 5, 2022 13:09
@sofurihafesofurihafe marked this pull request as draftJuly 5, 2022 13:09
@EgorkaKulikovEgorkaKulikov removed the comp-codegenIssue is related to code generator labelJul 5, 2022
@EgorkaKulikovEgorkaKulikov linked an issueJul 5, 2022 that may beclosed by this pull request
@sofurihafesofurihafeforce-pushed theandrey-t/minimize-signature-exceptions branch from4e83a9c toeebd835CompareJuly 5, 2022 13:30
Copy link
Member

@DamtevDamtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall, LGTM

@sofurihafesofurihafeforce-pushed theandrey-t/minimize-signature-exceptions branch from0b82bcb to3bd66fcCompareJuly 5, 2022 14:43
@sofurihafesofurihafeforce-pushed theandrey-t/minimize-signature-exceptions branch 5 times, most recently from166419c toc82c702CompareJuly 6, 2022 15:52
@sofurihafesofurihafeforce-pushed theandrey-t/minimize-signature-exceptions branch fromc82c702 to389b5c2CompareJuly 6, 2022 15:53
@EgorkaKulikovEgorkaKulikov self-requested a reviewJuly 6, 2022 16:59
Copy link
Member

@DamtevDamtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need to fix some problems withBuiltinClassId

@sofurihafesofurihafeforce-pushed theandrey-t/minimize-signature-exceptions branch from3e039e0 to4280aa0CompareJuly 7, 2022 10:50
@sofurihafesofurihafeforce-pushed theandrey-t/minimize-signature-exceptions branch from4280aa0 to59289abCompareJuly 7, 2022 11:12
@DamtevDamtev marked this pull request as ready for reviewJuly 7, 2022 12:12
Copy link
Member

@DamtevDamtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The big problem found, need to discuss

Copy link
Member

@DamtevDamtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Discussed, everything is OK

@EgorkaKulikovEgorkaKulikov merged commit31fbc83 intomainJul 8, 2022
@EgorkaKulikovEgorkaKulikov deleted the andrey-t/minimize-signature-exceptions branchJuly 8, 2022 07:50
rudolf101 added a commit that referenced this pull requestJul 8, 2022
commit31fbc83Author: Andrey Tarbeev <dinis.taranov@mail.ru>Date:   Fri Jul 8 10:50:52 2022 +0300    Minimize exceptions in signature (#418)    * Minimize exceptions in test methods signaturescommit63eb9b0Author: Yury Kamenev <yurkam447@gmail.com>Date:   Thu Jul 7 15:13:45 2022 +0300    Removed always used coverage-based minimization strategy (#450)commitfe0f7f8Author: Yury Kamenev <yurkam447@gmail.com>Date:   Thu Jul 7 14:19:53 2022 +0300    Disabled NPE checks for non-public library fields by default (#353)commitd1b51feAuthor: Yury Kamenev <yurkam447@gmail.com>Date:   Thu Jul 7 13:44:46 2022 +0300    Fixed NPE for processing static field as first statement in MUT (#433)commitacc2fffAuthor: Nikita Vlaev <nikitavlaev00@gmail.com>Date:   Wed Jul 6 15:37:28 2022 +0300    Added ForceStaticMockListener to run "configure mockito-inline" action.    Refactored url listener in notifications.commit80c2328Author: Nikita Stroganov <54814796+IdeaSeeker@users.noreply.github.com>Date:   Thu Jul 7 11:21:13 2022 +0300    Support -P parameters in the utbot-gradle (#377)commita92e289Author: Sergey Pospelov <sergeypospelov59@gmail.com>Date:   Tue Jul 5 10:29:45 2022 +0300    Fix searching of modifiers field for JDK 8-17commit9a3acb6Author: Amandel Pie <105506115+amandelpie@users.noreply.github.com>Date:   Wed Jul 6 14:16:09 2022 +0300    Disabled clustering of tests generated by Fuzzer (#431)    * Disabled clustering of tests generated by Fuzzer    * Refactored the multiple callscommitc09568fAuthor: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>Date:   Wed Jul 6 10:21:52 2022 +0300    Existing test file without test class obstruct generation#160 (#425)commit2ec8fb3Author: Denis Fokin <Denis.Fokin@gmail.com>Date:   Tue Jul 5 16:52:42 2022 +0300    Better namingcommit68c66efAuthor: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>Date:   Tue Jul 5 19:51:55 2022 +0300    SVG logo contains 'inaccurate' holes#330 (#411)commit1d48789Author: Dmitrii Timofeev <dtim@comitative.com>Date:   Tue Jul 5 17:08:38 2022 +0300    Workaround: run concrete execution for invokedynamiccommit65d95c1Author: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>Date:   Tue Jul 5 19:42:55 2022 +0300    Plugin fails with an exception if no SDK is configured for the test module#399 (#424)commit6f9f2d8Author: Maksim Pelevin <maks.pelevin@gmail.com>Date:   Tue Jul 5 17:49:58 2022 +0300    Fix CNFE: kotlin.collections.ArrayDeque in ContestEstimator (#419)commit67cc7d9Author: Denis Fokin <Denis.Fokin@gmail.com>Date:   Tue Jul 5 11:58:40 2022 +0300    Put concrete executor jar in resources for contest estimatorcommit63e2252Author: Alena Lisevych <37301492+alisevych@users.noreply.github.com>Date:   Tue Jul 5 15:48:29 2022 +0300    Tooltips correction for#343 (#410)    Co-authored-by: Alena Lisevych <>commit8b3defaAuthor: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>Date:   Tue Jul 5 13:22:31 2022 +0300    Write access exception on test generating in Idea project with JDK 11#350 (#409)commitc02883cAuthor: Amandel Pie <105506115+amandelpie@users.noreply.github.com>Date:   Tue Jul 5 11:21:21 2022 +0300    Enables 40 tests for utbot-summary module (#389)    * Repair testPow    * Repaired ReturnExampleTest tests    * Restored SummaryCycleTest.kt    * Restored all the testscommit65c07f8Author: Victoria <32179813+victoriafomina@users.noreply.github.com>Date:   Tue Jul 5 09:51:44 2022 +0300    Update Dockerfile_java_cli (#396)commit3b21112Author: Alexey Menshutin <alex.menshutin99@gmail.com>Date:   Mon Jul 4 21:16:53 2022 +0300    ToString support for abstract collection using makeSymbolic#391commitc2673dfAuthor: Vassiliy Kudryashov <vassiliy.kudryashov@gmail.com>Date:   Mon Jul 4 21:56:43 2022 +0300    IDE fatal error during tests generation#68 (#379)commit43693fbAuthor: Nikita Vlaev <vlaev.nikita@huawei.com>Date:   Mon Jul 4 18:59:57 2022 +0300    Bring back test class generation (#403)commit1c01193Author: Yury Kamenev <yurkam447@gmail.com>Date:   Mon Jul 4 20:24:03 2022 +0300    Added the wrapper for static methods of java.util.List (#400)commita805f31Author: Nikita Vlaev <vlaev.nikita@huawei.com>Date:   Fri Jul 1 20:16:28 2022 +0300    Add title pane with unsupported jdk notification (#373)commit16c13fbAuthor: Dmitrii Timofeev <dtim@comitative.com>Date:   Mon Jul 4 18:35:36 2022 +0300    Initiate concrete execution if a wrapper method is missing (#392)    If a JVM class is overridden but a method is missing from the wrapper,    the engine will discard the path and fall back to concrete execution    instead of analysing the real JVM code graph.    This approach fixes the problem with methods that have been introduced    in newer JDKs. Now wrappers are mostly limited to Java 1.8 interfaces    and fail to analyze methods like `String::isBlank` or `String::lines`    when the code runs under JDK 11. Building graphs from the real JDK code    fails because the wrapper does not have private fields that the original    code uses.    TODO: to allow symbolic analysis of the code, missing methods should be    actually implemented in corresponding wrappers.
Vassiliy-Kudryashov pushed a commit that referenced this pull requestJul 11, 2022
* Minimize exceptions in test methods signatures
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@EgorkaKulikovEgorkaKulikovEgorkaKulikov approved these changes

@DamtevDamtevDamtev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Minimize exceptions in test methods signature Redundant exceptions in parametrized tests data provider methods signatures

4 participants

@sofurihafe@EgorkaKulikov@Damtev

[8]ページ先頭

©2009-2025 Movatter.jp