- Notifications
You must be signed in to change notification settings - Fork45
Make fuzzer use static methods to create arbitrary objects#2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| privatefunfindAccessibleCreators(description:FuzzedDescription,classId:ClassId):Sequence<ExecutableId>= | ||
| (classId.allConstructors+ (classId.jClass.methods | ||
| .filter { it.isStatic&& it.returnType.id.isSubtypeOf(classId) } |
MarkoutteJul 25, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you, please, check what will happen if generics are used? Something like:
classA<T> {publicstaticA<String>getStringTyped() {returnnewA<>("Test") }privateA(Tvalue) {};}...publicvoidtestedMethod(A<Integer>expected) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It will erroneously usegetStringTyped() to createA<Integer>. I was assuming that java fuzzer doesn't attempt to fully respect generic types here, since similar issue could have been reproduced even before this pull request:
interfaceA<T> {Tget();}classAImplimplementsA<String> {@OverridepublicStringget() {return"Test"; } }...publicvoidtestedMethod(A<Integer>expected) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair enough, I tried to fix it with#2451. Please, review it when it is possible. I think same can be done for this PR when 2451 is merged.
6d93b45 to400f616Compare
Description
Now fuzzer can use both static methods and constructors to create instances of arbitrary types.
Fixes#2437
How to test
Automated tests
Self-check list