- Notifications
You must be signed in to change notification settings - Fork45
Enable Java 8 for contest estimator#1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
denis-fokin wants to merge1 commit intomainChoose a base branch fromdenis-fokin/enable_java8_for_contest_estimator
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3b71523 to7fb91a8Compare7fb91a8 toe780dbcComparee780dbc to4da0d67CompareDomonion requested changesJan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This changes does not bring JDK 8 to Contest Estimator, see Issues tree from#1736. I think its worth adding this changes without jdk8Jar
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
comp-contest-estimatorIssue is related to contest estimator ctg-enhancementNew feature, improvement or change request
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
SBST competition requires us generating and running tests with Java 8. While it seems reasonable to switch JAVA_HOME to Java 8, it will break others projects. We have to switch only the project specific to tests generated by the contest estimator.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Regression and integration tests
Local run
Automated Testing
CI run
Manual Scenario
Checklist (remove irrelevant options):
This is the author self-check list