Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enable Java 8 for contest estimator#1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
denis-fokin wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromdenis-fokin/enable_java8_for_contest_estimator

Conversation

@denis-fokin
Copy link
Collaborator

@denis-fokindenis-fokin commentedJan 18, 2023
edited
Loading

Description

SBST competition requires us generating and running tests with Java 8. While it seems reasonable to switch JAVA_HOME to Java 8, it will break others projects. We have to switch only the project specific to tests generated by the contest estimator.

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Regression and integration tests

Local run

Automated Testing

CI run

Manual Scenario

  1. Specify path to Java 8 rt.jar in gradle.properties (jdk8Jar)
  2. Run contest estimator for spoon project
  3. Execute :utbot-junit-contest:test task
  4. Check that IDE shows test run results

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@denis-fokindenis-fokinforce-pushed thedenis-fokin/enable_java8_for_contest_estimator branch 2 times, most recently from3b71523 to7fb91a8CompareJanuary 18, 2023 15:46
@denis-fokindenis-fokin marked this pull request as draftJanuary 18, 2023 15:55
@denis-fokindenis-fokinforce-pushed thedenis-fokin/enable_java8_for_contest_estimator branch from7fb91a8 toe780dbcCompareJanuary 19, 2023 07:17
@denis-fokindenis-fokinforce-pushed thedenis-fokin/enable_java8_for_contest_estimator branch frome780dbc to4da0d67CompareJanuary 19, 2023 08:45
@denis-fokindenis-fokin marked this pull request as ready for reviewJanuary 19, 2023 08:46
@DomonionDomonion mentioned this pull requestJan 23, 2023
@alisevychalisevych added ctg-enhancementNew feature, improvement or change request comp-contest-estimatorIssue is related to contest estimator labelsJan 24, 2023
Copy link
Collaborator

@DomonionDomonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This changes does not bring JDK 8 to Contest Estimator, see Issues tree from#1736. I think its worth adding this changes without jdk8Jar

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@DomonionDomonionDomonion requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

comp-contest-estimatorIssue is related to contest estimatorctg-enhancementNew feature, improvement or change request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denis-fokin@Domonion@alisevych

[8]ページ先頭

©2009-2025 Movatter.jp