- Notifications
You must be signed in to change notification settings - Fork45
Consider containingClass when matching psi methods and KFuncitons #1398#1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
volivan239 merged 1 commit intomainfromvolivan239/fix_no_methods_found_for_abstract_inheritorDec 16, 2022
Merged
Consider containingClass when matching psi methods and KFuncitons #1398#1502
volivan239 merged 1 commit intomainfromvolivan239/fix_no_methods_found_for_abstract_inheritorDec 16, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Domonion approved these changesDec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
// Note that rules for obtaining signature here should correlate with PsiMethod.signature()
Hope it will be always correlated)
sergeypospelov approved these changesDec 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To get
ExecutableIds of methods selected in plugin, we have to somehow match psi methods with reflections of the corresponding loaded methods. Previously we did matching bySignature, but it was not sufficient, e.g. abstract method and its implementation would have the sameSignature. This PR replacesSignaturewithMethodDescriptionwhich includes signature, but also hascontainingClassparameter.Fixes#1398
Type of Change
How Has This Been Tested?
Manual Scenario
Tested on the example from#1398 -- now the tests class with tests is generated for
PointChecklist (remove irrelevant options):
This is the author self-check list