NotificationsYou must be signed in to change notification settings
Fork45
Star142

Add a flag to disable imports addition from formatter side#1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EgorkaKulikov merged 1 commit intomainfromandrey-t/repeating-imports

Nov 22, 2022

Merged

Add a flag to disable imports addition from formatter side#1410

EgorkaKulikov merged 1 commit intomainfromandrey-t/repeating-imports

Nov 22, 2022

Conversation

Copy link

Member

sofurihafe commentedNov 22, 2022

Description

Choosing a different package as a test source root may lead to unnecessary repeating imports being rendered. The cause was that formatter was able to add extra imports when there was a method (which is from a different package) invocation. This PR fixes prohibits such behavior.

Fixes # (1286)

Type of Change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Automated Testing

utbot-samples.

Manual Scenario

OpenUTBotJava project, generate tests for theorg.utbot.examples.exceptions.ExceptionExamples class choosing different package as atest source root location. Verify that the generated code has no repeating imports as it was described in the issue:

packageorg.utbot.examples.exceptions;importorg.junit.jupiter.api.Test;importorg.junit.jupiter.api.DisplayName;importstaticorg.junit.jupiter.api.Assertions.assertEquals;importstaticorg.junit.jupiter.api.Assertions.assertThrows;importstaticorg.utbot.runtime.utils.java.UtUtils.createInstance;publicfinalclassExceptionExamplesTest {    <...>}