- Notifications
You must be signed in to change notification settings - Fork45
Handle not-nullable parameters in Kotlin constructors correctly #1336#1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
volivan239 merged 1 commit intomainfromvolivan239/fix_not_nullable_parameters_in_constructorsNov 15, 2022
Merged
Handle not-nullable parameters in Kotlin constructors correctly #1336#1352
volivan239 merged 1 commit intomainfromvolivan239/fix_not_nullable_parameters_in_constructorsNov 15, 2022
+16 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
EgorkaKulikov approved these changesNov 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If constructor in Kotlin code has not-nullable reference parameter, compiler adds instructions calling
kotlin/jvm/internal/Intrinsics.checkNotNullParameter. But in constructor analyzer we accept constructors iff they "contain only statements matching patternthis.a = somethingwhereais an argument of the constructor". Therefore, we need to add exception for calls to the function above. Also, these calls may reorder local variables, so minor changes inindexToFieldwere neededFixes#1336
Type of Change
How Has This Been Tested?
Manual Scenario
Checked on example from#1336 -- works as expected (but only when settings are Fuzzer 100%, engine creates only tests where parameter is null, which do not pass concrete executor -- see#1257)
Checklist (remove irrelevant options):
This is the author self-check list