Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove name field from BuiltinClassId#1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EgorkaKulikov merged 5 commits intomainfromegor/name_builtins
Oct 21, 2022
Merged

Conversation

@EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikovEgorkaKulikov commentedOct 20, 2022
edited
Loading

Description

BuiltinClassId should avoid settingname field because it is always similar tocanonicalName for it.
Setting it directly incorrectly lead to some problems.

Type of Change

  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Automated Testing

Standard utbot pipeline

@EgorkaKulikovEgorkaKulikov marked this pull request as draftOctober 20, 2022 12:49
@EgorkaKulikovEgorkaKulikov marked this pull request as ready for reviewOctober 20, 2022 12:56
@EgorkaKulikovEgorkaKulikov marked this pull request as draftOctober 20, 2022 13:29
@EgorkaKulikovEgorkaKulikov marked this pull request as ready for reviewOctober 20, 2022 19:44
@EgorkaKulikovEgorkaKulikov removed the request for review fromvolivan239October 21, 2022 06:54
@EgorkaKulikovEgorkaKulikov merged commit80a962b intomainOct 21, 2022
@EgorkaKulikovEgorkaKulikov deleted the egor/name_builtins branchOctober 21, 2022 06:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@DamtevDamtevDamtev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorkaKulikov@Damtev

[8]ページ先頭

©2009-2025 Movatter.jp