- Notifications
You must be signed in to change notification settings - Fork45
Linux engine process fix#1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fixing ubuntu process start and log creating
40fd4f1 to4fd17d4Compare
dtim left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, and this PR fixes the issue.
| JdkInfoService.jdkInfoProvider.info.path.resolve("bin${File.separatorChar}${osSpecificJavaExecutable()}").toString() | ||
| val cp= (this.javaClass.classLoaderasPluginClassLoader).classPath.baseUrls.joinToString( | ||
| separator=";", | ||
| separator=if (isWindows)";"else":", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I understand thatcp is a classpath string and not a filesystem path in the strict sense, but maybeFile.pathSeparator could be used here? What do you think?
[utbot-rd]fixing ubuntu process start and log creating(cherry picked from commitc30841d)
[utbot-rd]fixing ubuntu process start and log creating
[utbot-rd]fixing ubuntu process start and log creating
Fixing ubuntu process start and log creating
Fixes#1118
Type of Change