- Notifications
You must be signed in to change notification settings - Fork45
Modificators processing in AssembleModelGenerator and UtBotFieldModificatorsSearcher corrected#1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
02fdc9e to122d408Comparec4444b7 to6049c5fCompare6049c5f to32a3394Compare…ssembleModelGenerator
c88756c tob12f7c3Comparevolivan239 requested changesOct 2, 2022
Collaborator
volivan239 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good PR, but please check the comments.
utbot-framework/src/main/kotlin/org/utbot/framework/assemble/AssembleModelGenerator.kt OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...amework/src/main/kotlin/org/utbot/framework/modifications/UtBotFieldsModificatorsSearcher.ktShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...amework/src/main/kotlin/org/utbot/framework/modifications/UtBotFieldsModificatorsSearcher.ktShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
volivan239 approved these changesOct 3, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull requestOct 17, 2022
…icatorsSearcher corrected (UnitTestBot#1029)* Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator* Apply review comments* Fixed test* One more correction for package names
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull requestOct 17, 2022
…icatorsSearcher corrected (UnitTestBot#1029)* Improve modificators analysis in UtBotFieldModificatorsSearcher and AssembleModelGenerator* Apply review comments* Fixed test* One more correction for package names
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Searcher of field modificators fixed for default package: in the previous implementation it considered all modificators appropriate if they are located in a default package.
Fixes # (1024)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
UtBotFieldModificatorsTest
Manual Scenario
Repeat the scenario described in the mentioned feature with fuzzer and concrete executor turned off.