- Notifications
You must be signed in to change notification settings - Fork45
Disable test generation for Kotlin getters/setters #911#1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
volivan239 merged 1 commit intomainfromvolivan239/disabling_tests_for_kotlin_getters_settersSep 23, 2022
Merged
Disable test generation for Kotlin getters/setters #911#1003
volivan239 merged 1 commit intomainfromvolivan239/disabling_tests_for_kotlin_getters_settersSep 23, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Vassiliy-Kudryashov approved these changesSep 23, 2022
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR disables test generation for Kotlin getters/setters in plugin. Currently, overridden getters/setters are not tested as well as default ones (generated by Kotlin), but as discussed with@korifey, we take this as the expected behavior.
Fixes#911
Type of Change
How Has This Been Tested?
Manual Scenario
Launch plugin on any class with properties -- getters/setters won't be proposed for testing (e.g. for the class from#911 the test action is disabled).
Checklist (remove irrelevant options):
This is the author self-check list