Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
/CMAQPublic
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Remove files from chemistry utilities causing problems on MAC and WINDOWS systems.#171

Merged
kmfoley merged 6 commits intoUSEPA:5.3.3+frombhutzell:update_v5333plus
May 7, 2022

Conversation

bhutzell
Copy link
Contributor

Contact:
Bill Hutzell/USEPA athutzell.bill@epa.gov

Type of code change:
bug fix

Description of changes:
Both the create_ebi and inline_phot_prerproc utilities have files in their source code directories that only differ in letter case in filenames such asUTIL/create_ebi/junit.F andUTIL/create_ebi/junit.f. The property does not cause problems on Linux systems but can cause problems on Window and Macintosh systems. The problem is easily removed because either, only one file is needed or neither file is needed to build these chemistry utilities. The pull request removes the unneeded files causing the problems and updates the makefile for the create_ebi utility. It also removes two unneeded files under UTIL/inline_phot_preproc/src while makes minor changes to build-run scripts for create_ebi and inline_phot_preproc.

Issue:
CMAQ public repository Issue #169

Summary of Impact:
None, but allows to more efficiently use the CMAQ repository and its utilities on Windows and Macintosh operating systems.

Tests conducted:

  1. On two different Linux systems, tests successfully compiled and executed create_ebi and inline_photo_preproc.
  2. On windows, usinggit for windows determined the pull request's changes to remove problems dealing filenames as the inability to change branches or incorrectly tracking file changes.

bhutzelland others added6 commitsApril 19, 2022 14:52
 deleted:    UTIL/create_ebi/src_RXNSU/junit.f deleted:    UTIL/inline_phot_preproc/src/CSQY_DATA.F deleted:    UTIL/inline_phot_preproc/src/CSQY_DATA.f deleted:    UTIL/inline_phot_preproc/src/CSQY_DATA_gen.f deleted:    UTIL/inline_phot_preproc/src/CSQY_DATA_old.fremove case dependendent file names or unneeded files
minor edit
        -changed junit.o to depend on junit.Fmodified:   UTIL/create_ebi/scripts/bldrun_create_ebi.csh        -changed path account for build-run script is in scripts subdirectory
        -change comment line on assumed path modified:   UTIL/inline_phot_preproc/bldrun.inline_phot_preproc.csh        -changed setting of CMAQ repository to relative path
@bhutzellbhutzell marked this pull request as draftMay 4, 2022 20:46
@bhutzellbhutzell marked this pull request as ready for reviewMay 4, 2022 20:47
@bhutzellbhutzell changed the titleUpdate v5333plusRemove files from chemistry utilities causing problems on MAC and WINDOWS systems.May 4, 2022
@kmfoleykmfoley merged commitad7374d intoUSEPA:5.3.3+May 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bhutzell@kmfoley

[8]ページ先頭

©2009-2025 Movatter.jp