The clear button will always be enabled, ifshowClearButton=true andmultiSelect=false.
The clear button behavior is redefined to act as clear+confirm in single selection mode.

Thiscloses#2379. This will provide a workaround for#898.

P.S. I'm not sure if this should count as a [FIX] or a [FEATURE], so it's not included in any title.

stoyanovski added the enhancement label

Jan 28, 2019

Copy link

Contributor

stoyanovski commentedJan 28, 2019•
edited
Loading

Hi@zypA13510,

Thank you for your contribution. I created internal incident regarding your pull-request. The colleagues from the corresponding team will check if it's relevant for their control.

Best Regards,
Oliver

Copy link

Contributor

niyap commentedJan 30, 2019

Hello@zypA13510 ,

As is described in your related incident:#2379
We will analyze and evaluate all possible interactions and then we will make the decision.

Thank you for your contribution. Your proposal(pull request) will be evaluated as well.
We will keep you in touch regarding the progress and our final decision.
For this reason, we are currently not able to approve your pull request.

Thanks again for your proactivity and contribution!

Regards,
Niya

Copy link

ContributorAuthor

zypA13510 commentedJan 31, 2019

Actually, this was submitted prior to the reply in 2379 (but probably not being tracked for some reasons?)

Copy link

Contributor

Shtilianova commentedMay 13, 2019

Internal record is 1980259563. The status of the issue will be updated here in GitHub.

zypA13510 force-pushed thepatch-SelectDialog branch from6ebcb1b to59fcc75Compare

August 10, 2019 20:13

zypA13510 added2 commits

August 14, 2019 19:06

sap.m.SelectDialog: Allow clear in single selection

7a0f07c

The clear button is always enabled now, if showClearButton=true and multiSelect=false.The clear button behavior is redefined to act as clear+confirm in single selection mode.

Fixed eslint error

beb5668

zypA13510 force-pushed thepatch-SelectDialog branch from59fcc75 tobeb5668Compare

August 14, 2019 11:07

Shtilianova added the in progress label

Apr 14, 2020

Copy link

CLAassistant commentedAug 5, 2020•
edited by cla-assistantbot
Loading

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}