Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: only parse arguments from first line of tag comment#1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@aabajyan
Copy link
Contributor

I had this issue, where I was trying to use customName annotation to rename methods and I noticed that it was also including a new line and the first word of the next line. For example:

/**@noSelf */declarenamespaceTestNamespace{/**     *@customName pass     * The first word should not be included.     **/functionfail():void;}TestNamespace.fail();

Would result in:

TestNamespace["pass\nThe"]()

The solution was pretty simple, I only had to get the first line before splitting it by space.
I ran the tests and everything passes. Let me know if there's other changes I need to make.

Zamiell reacted with thumbs up emoji
@Zamiell
Copy link
Contributor

nice work!

aabajyan reacted with heart emoji

@PerryvwPerryvw merged commit102a00a intoTypeScriptToLua:masterJul 17, 2025
5 checks passed
@aabajyanaabajyan deleted the fix-tag-first-line branchJuly 29, 2025 18:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aabajyan@Zamiell@Perryvw

[8]ページ先頭

©2009-2025 Movatter.jp