Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Auto publish language-extensions#1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
lolleko wants to merge6 commits intomaster
base:master
Choose a base branch
Loading
frompublish-language-extensions

Conversation

@lolleko
Copy link
Member

@lollekololleko commentedSep 4, 2023
edited
Loading

When. a release of the main package is created vianpm version, the subpackagelanguage-extensions will get bumped to the same version. Both will then be published to npm via GitHub Actions

Closes#1482

Neloreck reacted with thumbs up emoji
@Perryvw
Copy link
Member

I see that in the tstl package.json we have a dependency on"@typescript-to-lua/language-extensions": "1.0.0". I guess we should also be bumping that version to match the new version.

I am worried that in that case the build order becomes very important. We could not build (npm install) the version bump commit because the packages are not yet available...

@lolleko
Copy link
MemberAuthor

I see that in the tstl package.json we have a dependency on"@typescript-to-lua/language-extensions": "1.0.0". I guess we should also be bumping that version to match the new version.

I am worried that in that case the build order becomes very important. We could not build (npm install) the version bump commit because the packages are not yet available...

Good catch. I will think a bit about on how to solve this. AFAIK this dependency is only there to "force" users to download language-extensions alongside TSTL. My initial thoughts and possible solutions:

  1. Remove the dependency and let users install language-extensions manually if needed (not sure if that's good or not)
  2. Change the build order and do something likeextension bump ->publish extensions ->tstl bump ->tstl publish. However, this will be difficult with our current setup as we do the bumping locally and releasing via action.
  3. Don't automate just do it manually as you did just now and use the script from the DotA monorepo.
    To ensure we don't forgot about releasing an language-extension update in the future we could write a GitHub action that warns us if language-extensions files have been modified without being released.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LuaTable isEmpty() method not present in language-extensions.

3 participants

@lolleko@Perryvw

[8]ページ先頭

©2009-2025 Movatter.jp