Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork181
fix: add check to see in ownerSymbol parent is the global symbol#1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
starsprung wants to merge1 commit intoTypeScriptToLua:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
when determining when to transform global builtin calls.
| ){ | ||
| constownerType=context.checker.getTypeAtLocation(calledMethod.expression); | ||
| constownerSymbol=tryGetStandardLibrarySymbolOfType(context,ownerType); | ||
| if(!ownerSymbol||ownerSymbol.parent)return; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wondering if instead we shouldn't just be removing thisownerSymbol.parent, not really sure if it adds anything
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add check to see in ownerSymbol.parent is the global symbol when determining when to transform global builtin calls.
I'm not sure if this is the appropriate fix, but this change allows calls to
console.logto compile correctly when using the types from @types/node and not using thedomlib. They already work correctly with the type declarations inlib.dom.d.ts, due to a difference in structure:Node's typings wrapconsoleinsideglobal { }, which means it has a parent, whereas console fromlib.dom.d.tsdoesn't.E.g.
Input
tstl output without fix
tstl output with fix