Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added CRUD endpoints for automated_emails#25497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
cmraible wants to merge4 commits intochris-ny-771-add-automated_email-bookshelf-model
base:chris-ny-771-add-automated_email-bookshelf-model
Choose a base branch
Loading
fromchris-ny-772-add-automated_emails-crud-api-endpoints

Conversation

@cmraible
Copy link
Collaborator

@cmraiblecmraible commentedNov 20, 2025
edited
Loading

@coderabbitai
Copy link
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branchchris-ny-772-add-automated_emails-crud-api-endpoints

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsbot added the migration[pull request] Includes migration for review labelNov 20, 2025
@github-actions
Copy link
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (bothup() anddown())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@cmraiblecmraibleforce-pushed thechris-ny-771-add-automated_email-bookshelf-model branch from0a07b79 tocd97fb0CompareNovember 20, 2025 05:03
refhttps://linear.app/ghost/issue/NY-772Ghost needed admin API endpoints to manage automated emails for featureslike member welcome emails. This adds browse, read, add, edit, anddestroy endpoints at /ghost/api/admin/automated_emails with validationfor status, name, and lexical fields. Permissions are restricted toAdministrator and Admin Integration roles only, ensuring proper accesscontrol for this sensitive functionality.
@cmraiblecmraibleforce-pushed thechris-ny-772-add-automated_emails-crud-api-endpoints branch frome226f1f tofe2847fCompareNovember 20, 2025 05:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

migration[pull request] Includes migration for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmraible

[8]ページ先頭

©2009-2025 Movatter.jp