- Notifications
You must be signed in to change notification settings - Fork76
Closed
Description
When using the OraLogger (Link) the following code to append parameters is used often:
logger.append_param(p_params =>l_params, p_name => 'p_param1_todo', p_val => p_param1_todo);
This will always give me
G-1050: Avoid using literals in your code.
for p_name. Which is of course correct. But the alternative would be to have a constant for every parameter and variable of interest and in every proc/fkt which is in my opinion huge overkill as demonstrated here:
procedure todo_proc_name(p_param1_todo in varchar2) as l_my_important_var number := 1; l_my_important_var_logger constant varchar2(30) := 'l_my_important_var '; l_p_param1_todo_logger constant varchar2(30) := 'p_param1_todo'; l_scope constant logger_logs.scope%type := gc_scope_prefix || 'todo_proc_name'; l_params logger.tab_param; begin logger.append_param(p_params => l_params, p_name => l_p_param1_todo_logger , p_val => p_param1_todo); logger.log(constants.log_start, l_scope, null, l_params); ... l_my_important_var := 2; logger.append_param(p_params => l_params, p_name => l_my_important_var_logger , p_val => l_my_important_var ); logger.log(constants.log_end, l_scope, null, l_params ); end todo_proc_name;And the Logger Text ( logger.log_error('Hardcoded error text'); ) should also be ignored in my opinion.