- Notifications
You must be signed in to change notification settings - Fork76
Closed
Description
The examples inG-3145: Avoid using SELECT * directly from a table or view. violate ruleG-4320: Always label your loops..
Here's the suggested solution for bad example:
begin<<raise_salary>> for r_employeein (select*from employees ) loopemployee_api.calculate_raise_by_seniority( id_in=>r_employee.id ,salary_in=>r_employee.salary ,hiredate_in=>r_employee.hiredate ); end loop raise_salary;end;/
and here the suggested solution for the good example:
begin<<raise_salary>> for r_employeein (select id,salary,hiredatefrom employees ) loopemployee_api.calculate_raise_by_seniority( id_in=>r_employee.id ,salary_in=>r_employee.salary ,hiredate_in=>r_employee.hiredate ); end loop raise_salary;end;/