Commit9e88c81

Ink Open Source

authored and

committed

Add some missing test coverage to brush code

PiperOrigin-RevId: 788575668

1 parent249fb04 commit9e88c81Copy full SHA for 9e88c81

File tree

+19

-1

lines changed

+19

-1

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@`
`14`	`14`
`15`	`15`	`#include"ink/brush/brush_coat.h"`
`16`	`16`
	`17`	`+#include<string>`
	`18`	`+`
`17`	`19`	`#include"gmock/gmock.h"`
`18`	`20`	`#include"gtest/gtest.h"`
`19`	`21`	`#include"fuzztest/fuzztest.h"`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -281,7 +281,12 @@ TEST(BrushPaintTest, StringifyBlendMode) {`
`281`	`281`	`EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kSrcAtop),"kSrcAtop");`
`282`	`282`	`EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kSrcIn),"kSrcIn");`
`283`	`283`	`EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kSrcOver),"kSrcOver");`
	`284`	`+EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kDstOver),"kDstOver");`
`284`	`285`	`EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kSrc),"kSrc");`
	`286`	`+EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kDst),"kDst");`
	`287`	`+EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kSrcOut),"kSrcOut");`
	`288`	`+EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kDstAtop),"kDstAtop");`
	`289`	`+EXPECT_EQ(absl::StrCat(BrushPaint::BlendMode::kXor),"kXor");`
`285`	`290`	`EXPECT_EQ(absl::StrCat(static_cast<BrushPaint::BlendMode>(99)),`
`286`	`291`	`"BlendMode(99)");`
`287`	`292`	`}`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,16 @@ TEST(EasingFunctionTest, StringifySteps) {`
`71`	`71`	`"Steps{3, StepPosition(99)}");`
`72`	`72`	`}`
`73`	`73`
	`74`	`+TEST(EasingFunctionTest, StringifyStepPosition) {`
	`75`	`+EXPECT_EQ(absl::StrCat(EasingFunction::StepPosition::kJumpEnd),"kJumpEnd");`
	`76`	`+EXPECT_EQ(absl::StrCat(EasingFunction::StepPosition::kJumpStart),`
	`77`	`+"kJumpStart");`
	`78`	`+EXPECT_EQ(absl::StrCat(EasingFunction::StepPosition::kJumpNone),"kJumpNone");`
	`79`	`+EXPECT_EQ(absl::StrCat(EasingFunction::StepPosition::kJumpBoth),"kJumpBoth");`
	`80`	`+EXPECT_EQ(absl::StrCat(static_cast<EasingFunction::StepPosition>(99)),`
	`81`	`+"StepPosition(99)");`
	`82`	`+}`
	`83`	`+`
`74`	`84`	`TEST(EasingFunctionTest, StringifyEasingFunction) {`
`75`	`85`	`EXPECT_EQ(absl::StrCat(EasingFunction{}),"kLinear");`
`76`	`86`	`EXPECT_EQ(absl::StrCat(EasingFunction{EasingFunction::Predefined::kEaseIn}),`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`#include<cmath>`
`20`	`20`	`#include<cstdint>`
`21`	`21`	`#include<limits>`
	`22`	`+#include<string>`
`22`	`23`	`#include<tuple>`
`23`	`24`	`#include<utility>`
`24`	`25`	`#include<vector>`
`@@ -522,7 +523,7 @@ Domain<BrushCoat> ValidBrushCoat(DomainVariant variant) {`
`522`	`523`
`523`	`524`	`Domain<BrushFamily>ValidBrushFamily(DomainVariant variant) {`
`524`	`525`	`returnMap(`
`525`		`- [](absl::Span<const BrushCoat> coats,const std::string id,`
	`526`	`+ [](absl::Span<const BrushCoat> coats,const std::string& id,`
`526`	`527`	`const BrushFamily::InputModel& input_model) {`
`527`	`528`	`returnBrushFamily::Create(coats, id, input_model).value();`
`528`	`529`	`},`

Comments

(0)