Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit10ac860

Browse files
committed
Use latest helpers fromtypescript-eslint#8011
1 parent97883bc commit10ac860

File tree

1 file changed

+25
-38
lines changed

1 file changed

+25
-38
lines changed

‎packages/eslint-plugin/src/rules/thenable-in-promise-aggregators.ts

Lines changed: 25 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -63,47 +63,31 @@ export default createRule({
6363
returnfalse;
6464
}
6565

66-
// Is like Promise, or a class/interface extending from Promise
67-
functionisPromiseClassLike(program:ts.Program,type:ts.Type):boolean{
68-
if(type.isIntersection()){
69-
returntype.types.some(t=>isPromiseLike(program,t));
70-
}
71-
if(type.isUnion()){
72-
returntype.types.every(t=>isPromiseLike(program,t));
73-
}
74-
75-
constsymbol=type.getSymbol();
76-
if(!symbol){
77-
returnfalse;
78-
}
79-
80-
if(
81-
symbol.getName()==='Promise'&&
82-
isSymbolFromDefaultLibrary(program,symbol)
83-
){
84-
returntrue;
85-
}
86-
87-
if(symbol.flags&(ts.SymbolFlags.Class|ts.SymbolFlags.Interface)){
88-
constchecker=program.getTypeChecker();
89-
90-
for(constbaseTypeofchecker.getBaseTypes(typeasts.InterfaceType)){
91-
if(isPromiseLike(program,baseType)){
92-
returntrue;
93-
}
94-
}
95-
}
66+
functionisPromiseLike(program:ts.Program,type:ts.Type):boolean{
67+
returnisBuiltinSymbolLike(program,type,'Promise');
68+
}
9669

97-
returnfalse;
70+
functionisPromiseConstructorLike(
71+
program:ts.Program,
72+
type:ts.Type,
73+
):boolean{
74+
returnisBuiltinSymbolLike(program,type,'PromiseConstructor');
9875
}
9976

100-
// Is like PromiseConstructor, or a class/interface extending from Promise
101-
functionisPromiseLike(program:ts.Program,type:ts.Type):boolean{
77+
functionisBuiltinSymbolLike(
78+
program:ts.Program,
79+
type:ts.Type,
80+
symbolName:string,
81+
):boolean{
10282
if(type.isIntersection()){
103-
returntype.types.some(t=>isPromiseLike(program,t));
83+
returntype.types.some(t=>
84+
isBuiltinSymbolLike(program,t,symbolName),
85+
);
10486
}
10587
if(type.isUnion()){
106-
returntype.types.every(t=>isPromiseLike(program,t));
88+
returntype.types.every(t=>
89+
isBuiltinSymbolLike(program,t,symbolName),
90+
);
10791
}
10892

10993
constsymbol=type.getSymbol();
@@ -112,7 +96,7 @@ export default createRule({
11296
}
11397

11498
if(
115-
symbol.getName()==='PromiseConstructor'&&
99+
symbol.getName()===symbolName&&
116100
isSymbolFromDefaultLibrary(program,symbol)
117101
){
118102
returntrue;
@@ -122,7 +106,7 @@ export default createRule({
122106
constchecker=program.getTypeChecker();
123107

124108
for(constbaseTypeofchecker.getBaseTypes(typeasts.InterfaceType)){
125-
if(isPromiseClassLike(program,baseType)){
109+
if(isBuiltinSymbolLike(program,baseType,symbolName)){
126110
returntrue;
127111
}
128112
}
@@ -151,7 +135,10 @@ export default createRule({
151135
}
152136

153137
constcallerType=services.getTypeAtLocation(callee.object);
154-
if(!isPromiseLike(services.program,callerType)){
138+
if(
139+
!isPromiseConstructorLike(services.program,callerType)&&
140+
!isPromiseLike(services.program,callerType)
141+
){
155142
return;
156143
}
157144

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp